Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video.adoc: Document requirement for overclock for certain 4K modes #2542

Merged
merged 6 commits into from Jul 5, 2022
Merged

video.adoc: Document requirement for overclock for certain 4K modes #2542

merged 6 commits into from Jul 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2022

raspberrypi/linux#5038 makes certain 4K modes (and anything beyond) conditional on the BCM2711 core being overclocked to at least 600MHz - document this requirement.

@ghost
Copy link
Author

ghost commented May 17, 2022

This is a draft, since raspberrypi/linux#5038 is also a draft, so may change or disappear.

@JamesH65
Copy link
Contributor

Might be Github, but 1 is rendering as "1" not the superscript wanted.

@JamesH65
Copy link
Contributor

Might be Github, but 1 is rendering as "1" not the superscript wanted.

Hahahah, so, it actually rendered correctly in the comment. That's funny right there

<sup>1</sup> is rendering as "<sup>1</sup>"

@ghost
Copy link
Author

ghost commented May 18, 2022

Might be Github, but 1 is rendering as "1" not the superscript wanted.

Thanks - I need to set up a local build environment again - back in the markdown days that worked, but I believe we're sanitising HTML now, or something.

@lurch
Copy link
Contributor

lurch commented May 18, 2022

@ghost
Copy link
Author

ghost commented May 18, 2022

OK - try now. I'm open to suggestion as to whether or not the bold is required:

Screenshot 2022-05-18 204052
.

@ghost ghost changed the title Update video.adoc video.adoc: Document requirement for overclock for certain 4K modes May 20, 2022
@ghost ghost marked this pull request as ready for review May 26, 2022 11:32
@ghost
Copy link
Author

ghost commented May 26, 2022

Removed draft flag as raspberrypi/linux#5038 is about to integrate.

@lurch
Copy link
Contributor

lurch commented Jul 2, 2022

Can you revert the change to Makefile please?

Makefile Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jul 2, 2022

Apologies folks - I thought this one was ready to integrate - it is now.

I guess I need to stop using git add -A 😕

@aallan aallan added the ready to merge The OP says this PR is ready to merge? Anyone object? label Jul 3, 2022
@aallan
Copy link
Contributor

aallan commented Jul 3, 2022

Everyone happy? Ready to merge?

@lurch
Copy link
Contributor

lurch commented Jul 4, 2022

I just had a quick scan through https://www.raspberrypi.com/documentation/computers/config_txt.html and there doesn't seem to be any other places (on that page) where we've used a superscript number like this. I wonder if it might be better to just add a "needs overclock" (alongside the "Pi 4" text) in the existing "Notes" column:
Screenshot from 2022-07-05 00-55-41
...and then add a NOTE: block underneath the table explaining the overclocking requirement? 🤷‍♂️

@ghost
Copy link
Author

ghost commented Jul 5, 2022

I just had a quick scan through https://www.raspberrypi.com/documentation/computers/config_txt.html and there doesn't seem to be any other places (on that page) where we've used a superscript number like this. I wonder if it might be better to just add a "needs overclock" (alongside the "Pi 4" text) in the existing "Notes" column ...and then add a NOTE: block underneath the table explaining the overclocking requirement? man_shrugging

That sounds a bit like a recipe for disaster - having the explanation split in two. We have used superscript elsewhere in the docs, so there is precident.

@lurch
Copy link
Contributor

lurch commented Jul 5, 2022

Up to @aallan ...

@aallan
Copy link
Contributor

aallan commented Jul 5, 2022

I think we're okay.

@aallan aallan merged commit cc8e7fe into raspberrypi:develop Jul 5, 2022
@ghost ghost deleted the patch-3 branch July 5, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready to merge The OP says this PR is ready to merge? Anyone object?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants