eepmake: Fix parse_data sscanf #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`%2X` format string reads `sizeof(int)` bytes, but only 2 hexadecimal characters are supplied by `c` pointer which is 1 byte long. Using `%2hhX` tells sscanf to read sizeof(char) bytes or 1 byte. On system where sizeof(int) == sizeof(char) this is no issue but on other ones, the arithmetic operation `(unsigned int*)*data+data_len++` is increasing the pointer sizeof(int) bytes instead instead of 1 byte.
|
I forgot to emphasis that this issue can lead to a buffer overflow situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%2Xformat string readssizeof(int)bytes, but only 2 hexadecimal characters are supplied bycpointer which is 1 byte long.Using
%2hhXtells sscanf to read sizeof(char) bytes or 1 byte.On system where sizeof(int) == sizeof(char) this is no issue but on other ones, the arithmetic operation
(unsigned int*)*data+data_len++is increasing the pointer sizeof(int) bytes instead instead of 1 byte.