Skip to content

Commit

Permalink
brcmfmac: Disable power management
Browse files Browse the repository at this point in the history 
Disable wireless power saving in the brcmfmac WLAN driver. This is a
temporary measure until the connectivity loss resulting from power
saving is resolved.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
  • Loading branch information
Phil Elwell committed Mar 9, 2016
1 parent 14f0bba commit 1f13305
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2482,6 +2482,8 @@ brcmf_cfg80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *ndev,
* preference in cfg struct to apply this to
* FW later while initializing the dongle
*/
pr_info("power management disabled\n");
enabled = false;
cfg->pwr_save = enabled;
if (!check_vif_up(ifp->vif)) {

Expand Down

3 comments on commit 1f13305

@clivem
Copy link

@clivem clivem commented on 1f13305 Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phil, I'm not really understanding the purpose of this, but if the problem is anywhere it is in the hardware or firmware specific to the BRCM chipset used on Pi3B, not in the brcmfmac driver. The driver works fine with power management enabled, with other bcm43xx series hardware. (Is this an attempt to deal with those, brcmfmac: brcmf_sdio_hdparse: seq 106: sequence number error, expect 108, log messages I reported? Disabling power management didn't help.)

@popcornmix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:
https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=138312
https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=44044&start=425
https://discourse.osmc.tv/t/pi-3-wifi-unstable/14171

@clivem
Copy link

@clivem clivem commented on 1f13305 Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The ante has been upped, from "out of sequence" messages and crap throughput, to I cant access my Pi at all via on-board wifi with power management enabled on the BRCM wifi interface. I hadn't seen those forum threads..... ;)

Please sign in to comment.