bcm2835-camera: Fix timestamp calculation problem

Use div_s64_rem() to convert usec timestamp to timeval to avoid integer signedness bug.
raspberrypi · Sep 29, 2017 · 3192ba6 · 3192ba6
1 parent 7dc3bd0
commit 3192ba6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/drivers/media/platform/bcm2835/bcm2835-camera.c b/drivers/media/platform/bcm2835/bcm2835-camera.c
@@ -366,11 +366,11 @@ static void buffer_cb(struct vchiq_mmal_instance *instance,
  struct timeval timestamp;
  s64 runtime_us = pts -
  dev->capture.vc_start_timestamp;
- u32 div = 0;
- u32 rem = 0;
+ s64 div = 0;
+ s32 rem = 0;
 
  div =
- div_u64_rem(runtime_us, USEC_PER_SEC, &rem);
+ div_s64_rem(runtime_us, USEC_PER_SEC, &rem);
  timestamp.tv_sec =
  dev->capture.kernel_start_ts.tv_sec + div;
  timestamp.tv_usec =