Skip to content

Commit

Permalink
qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth
Browse files Browse the repository at this point in the history
[ Upstream commit 130f634 ]

Function qtnf_event_handle_external_auth calls memcpy without
checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Signed-off-by: Lee Gibson <leegib@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210419145842.345787-1-leegib@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
lgtux authored and gregkh committed May 19, 2021
1 parent ededc73 commit bece6ae
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/wireless/quantenna/qtnfmac/event.c
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,10 @@ qtnf_event_handle_external_auth(struct qtnf_vif *vif,
return 0;

if (ev->ssid_len) {
memcpy(auth.ssid.ssid, ev->ssid, ev->ssid_len);
auth.ssid.ssid_len = ev->ssid_len;
int len = clamp_val(ev->ssid_len, 0, IEEE80211_MAX_SSID_LEN);

memcpy(auth.ssid.ssid, ev->ssid, len);
auth.ssid.ssid_len = len;
}

auth.key_mgmt_suite = le32_to_cpu(ev->akm_suite);
Expand Down

0 comments on commit bece6ae

Please sign in to comment.