Skip to content

Commit

Permalink
brcmfmac: Don't promote INFO logging to ERR
Browse files Browse the repository at this point in the history
An unwanted side effect of enabling the BRCMDBG config setting is
redefining brcmf_info to be brcmf_err. This can be alarming to users
and makes it harder to spot real errors, so don't do it.

See: #4663

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
  • Loading branch information
pelwell authored and popcornmix committed Nov 22, 2021
1 parent 19b22b5 commit d5de5d6
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ void __brcmf_err(struct brcmf_bus *bus, const char *func, const char *fmt, ...);
#if defined(DEBUG) || defined(CONFIG_BRCM_TRACING)

/* For debug/tracing purposes treat info messages as errors */
#define brcmf_info brcmf_err
// #define brcmf_info brcmf_err

#define brcmf_info(fmt, ...) \
do { \
pr_info("%s: " fmt, __func__, ##__VA_ARGS__); \
} while (0)

__printf(3, 4)
void __brcmf_dbg(u32 level, const char *func, const char *fmt, ...);
Expand Down

0 comments on commit d5de5d6

Please sign in to comment.