Skip to content

Commit

Permalink
block: Remove useless IPI struct initialization
Browse files Browse the repository at this point in the history
rq_fifo_clear() reset the csd.list through INIT_LIST_HEAD for no clear
purpose. The csd.list doesn't need to be initialized as a list head
because it's only ever used as a list node.

Lets remove this useless initialization.

Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@fb.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
fweisbec authored and axboe committed Feb 24, 2014
1 parent 8b4922d commit d9a74df
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions include/linux/elevator.h
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,7 @@ enum {
#define rb_entry_rq(node) rb_entry((node), struct request, rb_node)

#define rq_entry_fifo(ptr) list_entry((ptr), struct request, queuelist)
#define rq_fifo_clear(rq) do { \
list_del_init(&(rq)->queuelist); \
INIT_LIST_HEAD(&(rq)->csd.list); \
} while (0)
#define rq_fifo_clear(rq) list_del_init(&(rq)->queuelist)

#else /* CONFIG_BLOCK */

Expand Down

0 comments on commit d9a74df

Please sign in to comment.