EEE disabled by default on kernel 4.19 / RPi3B+

[HiassofT]

Describe the bug
On kernel 4.19 (tested with latest rpi-update kernel 4.19.25) eee seems to be disabled by default. ethtool --show-eee displays

EEE Settings for eth0:
        EEE status: disabled
        Tx LPI: disabled
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  Not reported
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full

When checking with my benchtop power supply I noticed idle power consumption is about 2.4W instead of the usual about 2W.

Manually enabling eee via ethtool works though

root@raspbian:~# ethtool --set-eee eth0 tx-timer 600 advertise 0x28 eee on
root@raspbian:~# ethtool --show-eee eth0
EEE Settings for eth0:
        EEE status: enabled - active
        Tx LPI: 600 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full
root@raspbian:~# uname -a
Linux raspbian 4.19.25-v7+ #1205 SMP Mon Feb 25 18:19:20 GMT 2019 armv7l GNU/Linux

On current 4.14 raspbian kernel and on the latest 4.14 rpi-update kernel eee is enabled by default

EEE Settings for eth0:
        EEE status: enabled - active
        Tx LPI: 600 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full

[pelwell]

Thanks, HiassofT. With the 4.19 kernel, the EEE support is a property of the PHY (which has it's own DT node), so the property querying code needed an update. See 7f41587.

[HiassofT]

thanks a lot for the quick fix!

rpi-4.19.y tree tested fine, EEE is enabled by default and disabling via config.txt works, too