Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEE disabled by default on kernel 4.19 / RPi3B+ #2882

Closed
HiassofT opened this issue Mar 4, 2019 · 2 comments
Closed

EEE disabled by default on kernel 4.19 / RPi3B+ #2882

HiassofT opened this issue Mar 4, 2019 · 2 comments

Comments

@HiassofT
Copy link
Contributor

HiassofT commented Mar 4, 2019

Describe the bug
On kernel 4.19 (tested with latest rpi-update kernel 4.19.25) eee seems to be disabled by default. ethtool --show-eee displays

EEE Settings for eth0:
        EEE status: disabled
        Tx LPI: disabled
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  Not reported
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full

When checking with my benchtop power supply I noticed idle power consumption is about 2.4W instead of the usual about 2W.

Manually enabling eee via ethtool works though

root@raspbian:~# ethtool --set-eee eth0 tx-timer 600 advertise 0x28 eee on
root@raspbian:~# ethtool --show-eee eth0
EEE Settings for eth0:
        EEE status: enabled - active
        Tx LPI: 600 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full
root@raspbian:~# uname -a
Linux raspbian 4.19.25-v7+ #1205 SMP Mon Feb 25 18:19:20 GMT 2019 armv7l GNU/Linux

On current 4.14 raspbian kernel and on the latest 4.14 rpi-update kernel eee is enabled by default

EEE Settings for eth0:
        EEE status: enabled - active
        Tx LPI: 600 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full
pelwell pushed a commit that referenced this issue Mar 5, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Contributor

pelwell commented Mar 5, 2019

Thanks, HiassofT. With the 4.19 kernel, the EEE support is a property of the PHY (which has it's own DT node), so the property querying code needed an update. See 7f41587.

pelwell pushed a commit that referenced this issue Mar 5, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
pelwell pushed a commit that referenced this issue Mar 5, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@HiassofT
Copy link
Contributor Author

HiassofT commented Mar 5, 2019

thanks a lot for the quick fix!

rpi-4.19.y tree tested fine, EEE is enabled by default and disabling via config.txt works, too

@HiassofT HiassofT closed this as completed Mar 5, 2019
popcornmix pushed a commit that referenced this issue Mar 6, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 6, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 6, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix added a commit to raspberrypi/firmware that referenced this issue Mar 8, 2019
kernel: lan78xx: EEE support is now a PHY property
See: raspberrypi/linux#2882

kernel: config: Add CONFIG_FB_TFT_SH1106=m
See: raspberrypi/linux#2876

kernel: Fix for Pisound kernel module in Real Time kernel configuration
See: raspberrypi/linux#2873

kernel: allo-katana: Added mute stream func
See: raspberrypi/linux#2577

firmware: raspivid: Stop --raw option resetting --raw-format to YUV
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589

firmware: Fixed up overflow in microsecond timer
See: raspberrypi/userland#535
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Mar 8, 2019
kernel: lan78xx: EEE support is now a PHY property
See: raspberrypi/linux#2882

kernel: config: Add CONFIG_FB_TFT_SH1106=m
See: raspberrypi/linux#2876

kernel: Fix for Pisound kernel module in Real Time kernel configuration
See: raspberrypi/linux#2873

kernel: allo-katana: Added mute stream func
See: raspberrypi/linux#2577

firmware: raspivid: Stop --raw option resetting --raw-format to YUV
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=189830&start=25#p1432589

firmware: Fixed up overflow in microsecond timer
See: raspberrypi/userland#535
popcornmix pushed a commit that referenced this issue Mar 12, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 12, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 12, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 15, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 15, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 15, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 21, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Mar 21, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 2, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 2, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 2, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
artynet pushed a commit to artynet/rpi-linux that referenced this issue Apr 3, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 8, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 8, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Gadgetoid pushed a commit to Gadgetoid/linux that referenced this issue Apr 10, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 18, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 18, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 18, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Apr 23, 2019
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 2, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 13, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 20, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 20, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 28, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue May 28, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 3, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 3, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 12, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 17, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 24, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jun 28, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jul 8, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 9, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 10, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jul 11, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 18, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jul 19, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 20, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 21, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Jul 21, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
popcornmix pushed a commit that referenced this issue Jul 25, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this issue Jul 29, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: #2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Aug 8, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Aug 9, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Aug 10, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this issue Aug 10, 2024
commit e70170db7716095603100a605413201bf99eaa58 from
https://github.com/raspberrypi/linux.git rpi-6.6.y

Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
gibsson pushed a commit to boundarydevices/linux that referenced this issue Sep 2, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
gibsson pushed a commit to boundarydevices/linux that referenced this issue Sep 16, 2024
Now that EEE support is a property of the PHY, use the PHY's DT node
when querying the EEE-related properties.

See: raspberrypi/linux#2882

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants