Wrong (and missing) tag values in vcio.h

[lurch]

The file arch/arm/mach-bcm2708/include/mach/vcio.h is currently identical in the branches rpi-3.6.y, rpi-3.8.y, rpi-3.9.y and rpi-3.10.y (the rpi-3.2.27 branch has an older version of this file, but it too suffers from the identical defects as described below).

However I've been comparing it to https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface and the following tag values are wrong in vcio.h:
VCMSG_GET_BOARD_REVISION, VCMSG_GET_BOARD_MAC_ADDRESS, VCMSG_GET_BOARD_SERIAL, VCMSG_GET_ARM_MEMORY, VCMSG_GET_VC_MEMORY, VCMSG_GET_CLOCKS
vcio.h lists them as 0x0002... whereas the firmware wiki lists them as 0x0001... (I've written test code to verify that the 0x0001... values are correct).

Also, the following tags (which are documented on the firmware wiki) are missing from vcio.h:
0x0003000a (Get max temperature), 0x0003000c (Allocate Memory), 0x0003000d (Lock memory), 0x0003000e (Unlock memory), 0x0003000f (Release Memory), 0x00030010 (Execute Code), 0x00030020 (Get EDID block).

[lurch]

I've now managed to read through all of raspberrypi/firmware#47 which says that set pitch (and therefore test pitch) aren't supported raspberrypi/firmware#47 (comment)
Therefore, vcio.h probably shouldn't have definitions for VCMSG_TST_PITCH and VCMSG_SET_PITCH

There's also a few other values listed in vcio.h which aren't mentioned in the wiki documentation - are these valid tags which simply haven't been documented on the firmware wiki yet, or are they also invalid/unimplemented tags (like VCMSG_SET_PITCH) which should be removed from vcio.h ?

Full list of tags mentioned in https://github.com/raspberrypi/linux/blob/rpi-3.6.y/arch/arm/mach-bcm2708/include/mach/vcio.h but not mentioned on https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface : VCMSG_TST_BLANK_SCREEN, VCMSG_TST_PITCH, VCMSG_SET_PITCH, VCMSG_GET_LAYER, VCMSG_TST_LAYER, VCMSG_SET_LAYER, VCMSG_GET_TRANSFORM, VCMSG_TST_TRANSFORM, VCMSG_SET_TRANSFORM

[lurch]

I've just gone and checked, and it seems this bug is fixed on the rpi-3.12.y, rpi-3.16.y, rpi-3.17.y, rpi-3.18.y, rpi-3.18.y-rebase and rpi-3.19.y branches, and still broken on all the other (now inactive) branches.

So closing as fixed.