Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PPS modules for 64-bit builds of 5.4 #3593

Closed
trejan opened this issue May 3, 2020 · 3 comments
Closed

Missing PPS modules for 64-bit builds of 5.4 #3593

trejan opened this issue May 3, 2020 · 3 comments

Comments

@trejan
Copy link

trejan commented May 3, 2020

64-bit builds of the 5.4 kernel are missing the PPS modules (pps_core, pps-gpio and pps-ldisc). The other 32-bit builds of 5.4 and all builds of 4.19 do have the PPS modules.

./4.19.97+/kernel/drivers/pps/clients/pps-gpio.ko
./4.19.97+/kernel/drivers/pps/clients/pps-ldisc.ko
./4.19.97+/kernel/drivers/pps/pps_core.ko
./4.19.97-v7+/kernel/drivers/pps/clients/pps-gpio.ko
./4.19.97-v7+/kernel/drivers/pps/clients/pps-ldisc.ko
./4.19.97-v7+/kernel/drivers/pps/pps_core.ko
./4.19.97-v7l+/kernel/drivers/pps/clients/pps-gpio.ko
./4.19.97-v7l+/kernel/drivers/pps/clients/pps-ldisc.ko
./4.19.97-v7l+/kernel/drivers/pps/pps_core.ko
./4.19.97-v8+/kernel/drivers/pps/clients/pps-gpio.ko
./4.19.97-v8+/kernel/drivers/pps/clients/pps-ldisc.ko

./5.4.35+/kernel/drivers/pps/clients/pps-gpio.ko
./5.4.35+/kernel/drivers/pps/clients/pps-ldisc.ko
./5.4.35+/kernel/drivers/pps/pps_core.ko
./5.4.35-v7+/kernel/drivers/pps/clients/pps-gpio.ko
./5.4.35-v7+/kernel/drivers/pps/clients/pps-ldisc.ko
./5.4.35-v7+/kernel/drivers/pps/pps_core.ko
./5.4.35-v7l+/kernel/drivers/pps/clients/pps-gpio.ko
./5.4.35-v7l+/kernel/drivers/pps/clients/pps-ldisc.ko
./5.4.35-v7l+/kernel/drivers/pps/pps_core.ko

Diff between 4.19 and 5.4 version of arch/arm64/configs/bcm2711_defconfig shows these two config statements are missing:

CONFIG_PPS_CLIENT_LDISC=m
CONFIG_PPS_CLIENT_GPIO=m
pelwell added a commit that referenced this issue May 4, 2020
@pelwell
configs: Add missing PPS configs
4d5e599 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell added a commit that referenced this issue May 4, 2020
@pelwell
configs: Add missing PPS configs
9e3a60a 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented May 4, 2020

I can't explain how those options got lost - the history has been squashed - but they have been restored in rpi-5.4.y and rpi-5.6.y, and hopefully will remain from now on.

@trejan
Copy link
Author

trejan commented May 4, 2020

Thanks for the fix

@trejan trejan closed this as completed May 4, 2020
popcornmix pushed a commit that referenced this issue May 4, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
f4f20d1 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue May 4, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
a8bd0ef 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue May 11, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
72ce96a 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix added a commit to raspberrypi/firmware that referenced this issue May 12, 2020
@popcornmix
kernel: Bump to 5.4.40
5cb5ddd 
kernel: vc4_hdmi: Add CEC support for 2711
See: raspberrypi/linux#3601

kernel: overlays: Move fixed-clock nodes to the root
See: raspberrypi/linux#3607

kernel: bcm2835_isp fixes for constness
See: raspberrypi/linux#3592

kernel: video: bcm2708_fb: Disable FB if no displays found
See: raspberrypi/linux#3598

kernel: vc4_hdmi_phy: Fix typo in phy_get_cp_current
See: raspberrypi/linux#3594

kernel: configs: Add missing TOUCHSCREEN_RASPBERRYPI_FW=m
See: Hexxeh/rpi-firmware#223

kernel: configs: Add missing PPS configs
See: raspberrypi/linux#3593

kernel: overlays: gpio-keys: Avoid open-drain warnings
See: #1381

kernel: overlays: Make the i2c-gpio overlay safe again

kernel: ARM: dts: bcm2711: Allow 40-bit DMA for SPI
See: raspberrypi/linux#3570

firmware: In KMS mode, prevent use of the firmware rotations

firmware: power: Adjust ARM:AXI divider ratio if ARM freq > 1500 MHz

firmware: imx477: Remove STILLS flag from 720p mode

userland: tvservice: Fix freeze on old firmware
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue May 12, 2020
@popcornmix
kernel: Bump to 5.4.40
a36283a 
kernel: vc4_hdmi: Add CEC support for 2711
See: raspberrypi/linux#3601

kernel: overlays: Move fixed-clock nodes to the root
See: raspberrypi/linux#3607

kernel: bcm2835_isp fixes for constness
See: raspberrypi/linux#3592

kernel: video: bcm2708_fb: Disable FB if no displays found
See: raspberrypi/linux#3598

kernel: vc4_hdmi_phy: Fix typo in phy_get_cp_current
See: raspberrypi/linux#3594

kernel: configs: Add missing TOUCHSCREEN_RASPBERRYPI_FW=m
See: #223

kernel: configs: Add missing PPS configs
See: raspberrypi/linux#3593

kernel: overlays: gpio-keys: Avoid open-drain warnings
See: raspberrypi/firmware#1381

kernel: overlays: Make the i2c-gpio overlay safe again

kernel: ARM: dts: bcm2711: Allow 40-bit DMA for SPI
See: raspberrypi/linux#3570

firmware: In KMS mode, prevent use of the firmware rotations

firmware: power: Adjust ARM:AXI divider ratio if ARM freq > 1500 MHz

firmware: imx477: Remove STILLS flag from 720p mode

userland: tvservice: Fix freeze on old firmware
popcornmix pushed a commit that referenced this issue May 20, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
6858dfa 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue May 20, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
2bdf792 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 3, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
c212fe8 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 3, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
3e3d7e6 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/linux-mvista that referenced this issue Jun 8, 2020
@pelwell @cminyard
configs: Add missing PPS configs
fe4306c 
Source: kernel.org
MR: 103889
Type: Enhancement
Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y
ChangeID: 6858dfa860f51057cc20e65edea8298d85b1bd18
Description:

The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: raspberrypi/linux#3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
popcornmix pushed a commit that referenced this issue Jun 10, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
572d694 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 10, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
041ae24 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 17, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
6ad7d24 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 17, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
da8e891 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jun 26, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
e8addb5 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 1, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
16ebe55 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix pushed a commit that referenced this issue Jul 13, 2020
@pelwell @popcornmix
configs: Add missing PPS configs
33191b7 
The arm64 bcm2711_defconfig was inexplicably missing three PPS config
options. Add them, along with another missing option from
bcmrpi3_defconfig.

See: #3593

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@lightswitch05
Copy link

I'm using the 64-bit build of bookworm on a Pi 3 Model B+, and I'm having some issue getting a dev/pps device created. Looking at lsmod | grep pps, I see the pps_gpio module is loaded, but I'm no longer seeing pps_core as an available module.

I'm way outside of my depth here, so please forgive me if I'm mistake, but could the pps_core module been dropped again?

@lightswitch05 lightswitch05 mentioned this issue Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lightswitch05 @trejan @pelwell