Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcm512x fails to load under 3.17 #723

Closed
hifiberry opened this issue Nov 11, 2014 · 2 comments
Closed

pcm512x fails to load under 3.17 #723

hifiberry opened this issue Nov 11, 2014 · 2 comments

Comments

@hifiberry
Copy link

The pcm512x driver fails to load under Linux 3.17. This is caused by the power regulation code:

[ 11.595100] pcm512x 1-004d: Failed to get supply 'AVDD': -517
[ 11.614262] pcm512x 1-004d: Failed to get supplies: -517
[ 11.626529] i2c 1-004d: Driver pcm512x requests probe deferral

A short fix was removing the complete regulator code. After this, the driver loads.

As this regulator code is not used anywhere on the Raspberry Pi, removing this in this GIT tree would be a possible solution until this is fixed. I can provide a driver without this code if needed.

@popcornmix
Copy link
Collaborator

I've removed CONFIG_REGULATOR from default config on 3.17.
Reports are that this fixes hifiberry DAC+ with OpenELEC. See:
http://forum.kodi.tv/showthread.php?tid=192380&pid=1836596#pid1836596

It's also been removed from OpenELEC master config.

davet321 pushed a commit to davet321/rpi-linux that referenced this issue Nov 19, 2014
Corrects the following checkpatch gripes:

    WARNING: quoted string split across lines
    raspberrypi#95: FILE: drivers/mfd/ab3100-core.c:95:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    raspberrypi#139: FILE: drivers/mfd/ab3100-core.c:139:
    +			"write error (write test register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    raspberrypi#175: FILE: drivers/mfd/ab3100-core.c:175:
    +			"write error (send register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    raspberrypi#193: FILE: drivers/mfd/ab3100-core.c:193:
    +			"write error (read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    raspberrypi#241: FILE: drivers/mfd/ab3100-core.c:241:
    +			"write error (send first register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    raspberrypi#256: FILE: drivers/mfd/ab3100-core.c:256:
    +			"write error (read register page) "
    +			"%d bytes transferred (expected %d)\n",

    WARNING: quoted string split across lines
    raspberrypi#299: FILE: drivers/mfd/ab3100-core.c:299:
    +			"write error (maskset send address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    raspberrypi#314: FILE: drivers/mfd/ab3100-core.c:314:
    +			"write error (maskset read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    raspberrypi#334: FILE: drivers/mfd/ab3100-core.c:334:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: please, no spaces at the start of a line
    raspberrypi#374: FILE: drivers/mfd/ab3100-core.c:374:
    +  return blocking_notifier_chain_unregister(&ab3100->event_subscribers,$

    WARNING: Prefer seq_puts to seq_printf
    raspberrypi#458: FILE: drivers/mfd/ab3100-core.c:458:
    +	seq_printf(s, "AB3100 registers:\n");

    WARNING: quoted string split across lines
    raspberrypi#564: FILE: drivers/mfd/ab3100-core.c:564:
    +			 "debug write reg[0x%02x] with 0x%02x, "
    +			 "after readback: 0x%02x\n",

    WARNING: quoted string split across lines
    raspberrypi#723: FILE: drivers/mfd/ab3100-core.c:723:
    +			 "AB3100 P1E variant detected, "
    +			 "forcing chip to 32KHz\n");

    WARNING: quoted string split across lines
    raspberrypi#882: FILE: drivers/mfd/ab3100-core.c:882:
    +			"could not communicate with the AB3100 analog "
    +			"baseband chip\n");

    WARNING: quoted string split across lines
    raspberrypi#906: FILE: drivers/mfd/ab3100-core.c:906:
    +		dev_err(&client->dev, "accepting it anyway. Please update "
    +			"the driver.\n");

    total: 0 errors, 15 warnings, 999 lines checked

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
@pelwell
Copy link
Contributor

pelwell commented Dec 23, 2014

Can we close this now?

pfpacket pushed a commit to pfpacket/linux-rpi-rust that referenced this issue Apr 7, 2023
rust: convert `Credential` to use `ARef`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants