solved issue of mirroring screen after rotation. #1270
Conversation
|
We'll need more information on the problem and what this does. Really this is an upstream file and the patch should be submitted upstream: I can't judge whether this is a safe change and won't cause problems for other users. Ping @notro who may know about this. |
|
@notro, we have solved issue of 90 degree rotation for tinylcd 3.5 tft and voltage problems for new tinylcd tft's. the present init code for fb_tinylcd.c having an issue of 90 degree rotation, image showing its mirror after 90 degree rotation and also solved the voltage issue for new tft's with changing write_reg(par, 0xC1, 0x45, 0x07); to write_reg(par, 0xC1, 0x01, 0x01); |
|
fbtft is practically dead now. So there's no point in sending fbtft patches. Bug fixes might get in, but this seems to be a new display. I have been working on and off on a DRM version of fbtft and I have a hack with one display working (sort of), but it's still some work to be done before I can post some patches for review. |
|
Notify some more people about the current fbtft status: @ladyada @awatterott @mwilliams03 |
|
ok thanks for the notice! hopefully the raspi fork can keep it in? |
|
The intent is to get a rewrite using the DRM (Direct Rendering Manager) framework pushed upstream. Personally, I don't think it's likely that fbtft will be removed completely upstream until that happens, as the intent to eventually rewrite it using DRM has been stated on the mailing list. |
|
sad to know about "The fbdev maintainer won't accept any new fbdev drivers", hopefully the raspi fork can keep it in. |
|
As @Ferroin says, if I can come up with a drm version in a reasonable time, fbtft won't go away before there's an alternative. @tinylcd |
|
@notro np for the displays i have access to: HX5378D, ILI934x, SSDxxxx OLEDs, ST7735, etc. i've already done the code on an Arduino, so no biggie for me to re-port them again :) |
No. I have worked on and off with this for over a year now, but this time around I plan to keep going until I have sent an RFC patchset for review.
Sure. I will also post updates in this thread: notro/tinydrm#2 |
|
This PR is pointing to 4.1.y, is this ever going to be merged? |
|
No would need to be resubmitted to 4.4 tree if still desired, although in general we are reluctant to keep patches to upstream code in this tree (we'd prefer the changes went upstream). |
Fix up unprivileged test case results for 'Dest pointer in r0' verifier tests given they now need to reject R0 containing a pointer value, and add a couple of new related ones with 32bit cmpxchg as well. root@foo:~/bpf/tools/testing/selftests/bpf# ./test_verifier #0/u invalid and of negative number OK #0/p invalid and of negative number OK [...] #1268/p XDP pkt read, pkt_meta' <= pkt_data, bad access 1 OK #1269/p XDP pkt read, pkt_meta' <= pkt_data, bad access 2 OK #1270/p XDP pkt read, pkt_data <= pkt_meta', good access OK #1271/p XDP pkt read, pkt_data <= pkt_meta', bad access 1 OK #1272/p XDP pkt read, pkt_data <= pkt_meta', bad access 2 OK Summary: 1900 PASSED, 0 SKIPPED, 0 FAILED Acked-by: Brendan Jackman <jackmanb@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
commit e523102 upstream. Fix up unprivileged test case results for 'Dest pointer in r0' verifier tests given they now need to reject R0 containing a pointer value, and add a couple of new related ones with 32bit cmpxchg as well. root@foo:~/bpf/tools/testing/selftests/bpf# ./test_verifier #0/u invalid and of negative number OK #0/p invalid and of negative number OK [...] #1268/p XDP pkt read, pkt_meta' <= pkt_data, bad access 1 OK #1269/p XDP pkt read, pkt_meta' <= pkt_data, bad access 2 OK #1270/p XDP pkt read, pkt_data <= pkt_meta', good access OK #1271/p XDP pkt read, pkt_data <= pkt_meta', bad access 1 OK #1272/p XDP pkt read, pkt_data <= pkt_meta', bad access 2 OK Summary: 1900 PASSED, 0 SKIPPED, 0 FAILED Acked-by: Brendan Jackman <jackmanb@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
changed init code for rotation & new tft voltage problem.