add sound-dai-cells to I2S def #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add '#sound-dai-cells = <0>;' to the I2S definition in bcm2708_common.dtsi Not having it specified, whilst not causing an issue right now with rpi-4.4.y, is going to cause an issue going forward with the use of simple-card driver. So it doesn't fall through the cracks, patch it in now. Hopefully Martin has taken care of getting a patch submitted for the upstream Pi dts, as it was he who first run into the issue with the current upstream kernel.... msperl#3 (comment) Signed-off-by: DigitalDreamtime <clive.messer@digitaldreamtime.co.uk>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 31, 2016
See: raspberrypi/linux#1485 kernel: bcm2835-camera: Fix max/min error when looping over cameras/resolutions See: raspberrypi/linux#1447 (comment) kernel: Add dt param to force HiFiBerry DAC+ Pro into slave mode See: raspberrypi/linux#1501 kernel: simple: add sound-dai-cells to I2S def See: raspberrypi/linux#1502 kernel: BCM2835-V4L2: Increase minimum resolution to 32x32 See: raspberrypi/linux#1505 kernel: config: Add support for Logitech Rumblepad See: raspberrypi/linux#1496 firmware: arm_loader: Add simple-framebuffer support for vc4-kms-v3d firmware: dtoverlay: Improve compatibility libdtovl: Simplify target-path handling See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: bootcode: Fix LED for A+ and B+ See: https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=135813 firmware: cmake: generate and install pkgconfig files See: raspberrypi/userland#245 documentaton: IL Components: Documentation update from latest source
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 31, 2016
See: raspberrypi/linux#1485 kernel: bcm2835-camera: Fix max/min error when looping over cameras/resolutions See: raspberrypi/linux#1447 (comment) kernel: Add dt param to force HiFiBerry DAC+ Pro into slave mode See: raspberrypi/linux#1501 kernel: simple: add sound-dai-cells to I2S def See: raspberrypi/linux#1502 kernel: BCM2835-V4L2: Increase minimum resolution to 32x32 See: raspberrypi/linux#1505 kernel: config: Add support for Logitech Rumblepad See: raspberrypi/linux#1496 firmware: arm_loader: Add simple-framebuffer support for vc4-kms-v3d firmware: dtoverlay: Improve compatibility libdtovl: Simplify target-path handling See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: bootcode: Fix LED for A+ and B+ See: https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=135813 firmware: cmake: generate and install pkgconfig files See: raspberrypi/userland#245 documentaton: IL Components: Documentation update from latest source
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
See: raspberrypi/linux#1485 kernel: bcm2835-camera: Fix max/min error when looping over cameras/resolutions See: raspberrypi/linux#1447 (comment) kernel: Add dt param to force HiFiBerry DAC+ Pro into slave mode See: raspberrypi/linux#1501 kernel: simple: add sound-dai-cells to I2S def See: raspberrypi/linux#1502 kernel: BCM2835-V4L2: Increase minimum resolution to 32x32 See: raspberrypi/linux#1505 kernel: config: Add support for Logitech Rumblepad See: raspberrypi/linux#1496 firmware: arm_loader: Add simple-framebuffer support for vc4-kms-v3d firmware: dtoverlay: Improve compatibility libdtovl: Simplify target-path handling See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=139732 firmware: bootcode: Fix LED for A+ and B+ See: https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=135813 firmware: cmake: generate and install pkgconfig files See: raspberrypi/userland#245 documentaton: IL Components: Documentation update from latest source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '#sound-dai-cells = <0>;' to the I2S defintion in bcm2708_common.dtsi
Not having it specified, whilst not causing an issue right now with
rpi-4.4.y, is going to cause an issue going forward with the use of
simple-card driver. So it doesn't fall through the cracks, patch it
in now.
Hopefully @msperl has taken care of getting a patch submitted for the
upstream Pi dts, as it was he who first run into the issue with the
current upstream kernel....
msperl#3 (comment)