Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay for Microchip MCP23S08/17 SPI gpio expanders #1566

Merged
merged 6 commits into from
Aug 19, 2016
Merged

Overlay for Microchip MCP23S08/17 SPI gpio expanders #1566

merged 6 commits into from
Aug 19, 2016

Conversation

wavelet2
Copy link

No description provided.

pelwell
pelwell reviewed Aug 9, 2016
View reviewed changes
arch/arm/boot/dts/overlays/README
If interrupts are enabled for a device on a given CS# on a SPI bus, that
device must be the only one present on that SPI bus/CS#.
Load: dtoverlay=mcp23s17,<param>=<val>
Params: mcp23s08-spi<n>-<m>-present 4-bit interger, bitmap indicating MCP23S08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integer is the correct spelling.

@pelwell
Copy link
Contributor

pelwell commented Aug 9, 2016

In addition to fixing the formatting issues you will also need to add a line to .../overlays/Makefile, otherwise the overlay will not be compiled.

@pelwell
Copy link
Contributor

pelwell commented Aug 9, 2016

I also think that the support for both underscores and hyphens doesn't serve any useful purpose, and it makes the file even more unwieldy; I would suggest standardizing on one (most overlays have used underscores). Whichever you settle on, make sure the README agrees.

@wavelet2
Update mcp23s17-overlay.dts
47a57f7 
Fixed spelling error.  Removed underscore option for dtparams.
@wavelet2
Update README
e6062e8 
Corrected spelling of 'integer'.  Shortened dtparam names to comply with indenting rules.
@wavelet2
Update mcp23s17-overlay.dts
3f0189f 
Shortened dtparam names.
@wavelet2
Update Makefile
796f6e5 
Added target for MCP23S08/17 overlay.
@wavelet2
Copy link
Author

pelwell, I have updated the files as you suggest and added a target to the Makefile. Regards, wavelet2.

@pelwell
Copy link
Contributor

pelwell commented Aug 19, 2016

Congratulations - you win the prize for the most complicated overlay yet. Your changes look good - nice job.

@pelwell pelwell merged commit 44b5a52 into raspberrypi:rpi-4.4.y Aug 19, 2016
@pelwell
Copy link
Contributor

pelwell commented Aug 19, 2016

Previously I would have asked you to squash your commits into one, but instead I used the new squash-and-merge feature to do it myself. This way works better because it preserves the history in the PR.

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Aug 19, 2016
@popcornmix
kernel: Bump to 4.4.18
58567cb 
kernel: config: Enable SERIAL_SC16IS7XX_SPI
See: raspberrypi/linux#1594

kernel: Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
See: raspberrypi/linux#1566

kernel: BCM270X_DT: Add audio_pins to CM dtb
kernel: BCM270X_DT: Don't enable UART0 in CM3 dtb

kernel: overlays: Add audremap overlay
kernel: overlays: Add swap_lr and enable_jack to audremap
See: raspberrypi/linux#1473

firmware: Raspi[Still|Vid]Yuv: Add option for just saving luma
See: raspberrypi/userland#170

firmware: RaspiVidYuv: Add option of saving RGB data

firmware: Only change I2C/GPIO pin functions when needed

firmware: platform: Redo the audio remapping logic
See: raspberrypi/linux#1473
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Aug 19, 2016
@popcornmix
kernel: Bump to 4.4.18
9e8f2d6 
kernel: config: Enable SERIAL_SC16IS7XX_SPI
See: raspberrypi/linux#1594

kernel: Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
See: raspberrypi/linux#1566

kernel: BCM270X_DT: Add audio_pins to CM dtb
kernel: BCM270X_DT: Don't enable UART0 in CM3 dtb

kernel: overlays: Add audremap overlay
kernel: overlays: Add swap_lr and enable_jack to audremap
See: raspberrypi/linux#1473

firmware: Raspi[Still|Vid]Yuv: Add option for just saving luma
See: raspberrypi/userland#170

firmware: RaspiVidYuv: Add option of saving RGB data

firmware: Only change I2C/GPIO pin functions when needed

firmware: platform: Redo the audio remapping logic
See: raspberrypi/linux#1473
popcornmix pushed a commit that referenced this pull request Aug 23, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
8c8f68e 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 3, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
cb4bd36 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 5, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
f8ef4e7 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 7, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
8460949 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 7, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
60d22b1 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 7, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
9b69148 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 14, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
0f02208 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 15, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
ebcaf69 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
mkreisl added a commit to xbianonpi/xbian-package-firmware that referenced this pull request Sep 16, 2016
@mkreisl
verup and fixes:
a0c6e4a 
- kernel: config: Enable SENSORS_LM75
  See: #508

- kernel: config: Enable SERIAL_SC16IS7XX
  See: raspberrypi/linux#1594

- kernel: snd-bcm2835: Don't allow responses from VC to be interrupted by user signals
  See: raspberrypi/linux#1560

- kernel: Merge many vc4 changes from drm-vc4-next-2016-07-15
  See: raspberrypi/linux#1596

- kernel: drm/vc4: vc4 loops support
  See: raspberrypi/linux#1597

- kernel: Add cm3 dts file
  See: raspberrypi/linux#1595

- kernel: net: ethernet: enc28j60: add device tree support

- kernel: enc28j60: Fix race condition in enc28j60 driver
  See: raspberrypi/linux#1385

- firmware: platform: Don't swap audio L&R if using GPIOs 12&13
  See: http://github.com/raspberrypi/linux/issues/1473

- firmware: hdmi: Increase muting before resolution change

- firmware: board_info: Add cm3-specific dtb file

- firmware: Ensure extended part of vg_spath is zeroed
  See: raspberrypi/linux#943

- kernel: config: Enable SERIAL_SC16IS7XX_SPI
  See: raspberrypi/linux#1594

- kernel: Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
  See: raspberrypi/linux#1566

- kernel: BCM270X_DT: Add audio_pins to CM dtb
- kernel: BCM270X_DT: Don't enable UART0 in CM3 dtb

- kernel: overlays: Add audremap overlay
- kernel: overlays: Add swap_lr and enable_jack to audremap
  See: raspberrypi/linux#1473

- firmware: Raspi[Still|Vid]Yuv: Add option for just saving luma
  See: raspberrypi/userland#170

- firmware: RaspiVidYuv: Add option of saving RGB data

- firmware: Only change I2C/GPIO pin functions when needed

- firmware: platform: Redo the audio remapping logic
  See: raspberrypi/linux#1473

- kernel: overlays: added sc16is750 UART over I2C
  See: raspberrypi/linux#1617

- kernel: config: Add CONFIG_IPVLAN module
  See: raspberrypi/linux#1612

- kernel: config: Add CONFIG_VXLAN module
  See: raspberrypi/linux#1614

- firmware: platform: Make the default UART0 clock 48MHz for all Pis
  See: raspberrypi/linux#1601
  See: #643

- firmware: cacheasm: Enable workaround for unwanted sdram write after flush/invalidate
  See: raspberrypi/linux#943

- firmware: vchiq_arm: Fix return value of vchiq_initialise
  See: raspberrypi/userland#331

- firmware: Revert temp: Ensure extended part of vg_spath is zeroed
  See: raspberrypi/linux#943

- firmware: MMAL: Support MMAL_ENCODING_xxx_SLICE formats

- firmware: arm_display: Add bitmapped icons for warning conditions
  See: #367

- firmware: deinterlace: Avoid frame doubling with progressive frames
  See: http://forum.kodi.tv/showthread.php?tid=269814&pid=2412845#pid2412845

- kernel: config: Enable SENSORS_INA2XX module
  See: raspberrypi/linux#1632

- kernel: overlays: Add dpi18 overlay
  See: raspberrypi/linux#1634

- kernel: brcmfmac: do not use internal roaming engine by default
  See: http://projectable.me/optimize-my-pi-wi-fi/

- firmware: arm_display: Fix alpha of warning icons
  See: #367

- firmware: mmal: Advertise sliced formats in MMAL_PARAMETER_SUPPORTED_ENCODINGS
- firmware: IL Resize: Accept strides greater than the minimum

- firmware: vmcs_host: Poll for multiple dispmanx messages
- firmware: VCHI clients: Poll for messages until empty
  See: https://discourse.osmc.tv/t/april-update-causes-system-freezes/15361/183

- firmware: tvservice/cecservice: Make unexpected messages more fatal

- kernel: drm/vc4: Allow some more signals to be packed with uniform resets
  See: raspberrypi/linux#1636

- kernel: Rpi 4.4.y firmware kms
  See: raspberrypi/linux#1637

- firmware: tvservice/cecservice: We only care about unexpected message sizes

- firmware: khronos: Avoid starting khronos service when vc4-kms-v3d is active
- firmeare: arm_loader: Enable fake_vsync_isr when fkms overlay is used
  See: raspberrypi/linux#1637

- firmware: vcdbg: Add support for vchiq debugging
popcornmix pushed a commit that referenced this pull request Sep 19, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
34856c4 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 24, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
7f26abb 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 29, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
167ba66 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Sep 30, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
4ca41c0 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Oct 3, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
743c1b6 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Oct 9, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
687fe66 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Oct 17, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
7e4af2f 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
popcornmix pushed a commit that referenced this pull request Oct 22, 2016
@wavelet2 @popcornmix
Overlay for Microchip MCP23S08/17 SPI gpio expanders (#1566)
53ba618 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
angyalp pushed a commit to angyalp/kernel_rpi that referenced this pull request Dec 19, 2016
@wavelet2 @angyalp
Overlay for Microchip MCP23S08/17 SPI gpio expanders (raspberrypi#1566)
49c951b 
Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
@popcornmix
kernel: Bump to 4.4.18
b044e9a 
kernel: config: Enable SERIAL_SC16IS7XX_SPI
See: raspberrypi/linux#1594

kernel: Added Overlay for Microchip MCP23S08/17 SPI gpio expanders
See: raspberrypi/linux#1566

kernel: BCM270X_DT: Add audio_pins to CM dtb
kernel: BCM270X_DT: Don't enable UART0 in CM3 dtb

kernel: overlays: Add audremap overlay
kernel: overlays: Add swap_lr and enable_jack to audremap
See: raspberrypi/linux#1473

firmware: Raspi[Still|Vid]Yuv: Add option for just saving luma
See: raspberrypi/userland#170

firmware: RaspiVidYuv: Add option of saving RGB data

firmware: Only change I2C/GPIO pin functions when needed

firmware: platform: Redo the audio remapping logic
See: raspberrypi/linux#1473
@jlemon jlemon mentioned this pull request Jun 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wavelet2 @pelwell