ARM64: Make it work in 4.10 + Add HDMI Audio and VCHIQ support #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Invoke the dtc compiler with the same options used in arm mode. * ARM64 now uses the bcm2835 platform just like ARM32. * ARM64: Update bcmrpi3_defconfig Signed-off-by: Michael Zoran <mzoran@crowfest.net>
The function vchiq_copy_from_user contains a non-portable cast to uint32_t. Convert this to a cast to unsigned long which is portable. Signed-off-by: Michael Zoran <mzoran@crowfest.net>
In the messages sent to VCHIQ, SND_BCM2835 passes a callback and a context into two 32 bit pointers. Since this message is interpreted by the firmware, it can't be easily changed. Luckily only one of these fields is actual used, so on ARM64 only use one of the fields to store the upper half of the 64 bit callback pointer. The Kconfig is also changed to allow ARM audio to work for ARM64 as well. Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Michael Zoran <mzoran@crowfest.net>
|
I'm okay with this. Any objections @pelwell ? |
|
No objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes arm64 work again in 4.10. Here is a summary of the changes.
I tested the audio by playing some FLAC audio files and a DVD rip from VLC on debian sid with the xfce4 desktop. I enabled audio and VC4 video with the following config.txt parameters:
Ideally I would be great if this could somehow be back-ported to 4.9 since that's probably going to be the long term support release. That would require back-porting the upstream 4.10 of vchiq to 4.9 through.