dwc_otg: add module parameter int_ep_interval_min #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a module parameter (defaulting to ignored) that clamps the polling rate of high-speed Interrupt endpoints to a minimum microframe interval. The parameter is modifiable at runtime as it is used when activating new endpoints (such as on device connect).
|
Looks fine. If you want to enforce power of two then you could use (1<<int_ep_interval_min), but I'm happy to merge it as is. |
|
Technically using any integer interval would work, so it seems unnecessarily restrictive to enforce it. The USB spec requires servicing intervals in descriptors to be a power of two, but I doubt there would be any practical effect as we're servicing endpoints slower than requested anyway. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 13, 2017
See: raspberrypi/linux#2066 kernel: dwc_otg: add module parameter int_ep_interval_min See: raspberrypi/linux#2067 firmware: venc: Correct the validation on custom mb/mbps/br settings See: #819 firmware: vc_image: Remove structure definition duplication firmware: vc_image/mmal/il/isp: Add support for 16bit/component YUV420 and YUVUV firmware: vcdbg: Don't use dma when file provided firmware: rtos: Avoid sleeping delay when RTOS is not present firmware: bootcode: Remove reliance on scanf to reduce bootcode.bin size firmware: bootcode: Changes to force to full speed firmware: bootcode: Make sure bootcode drops out firmware: bootcode: Mass storage changes to power off/on USB block firmware: bootcode: Change USB 1.1 to have 64 byte endpoints firmware: bootcode: Set MSD serial number to be the Pi serial number
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jun 13, 2017
See: raspberrypi/linux#2066 kernel: dwc_otg: add module parameter int_ep_interval_min See: raspberrypi/linux#2067 firmware: venc: Correct the validation on custom mb/mbps/br settings See: raspberrypi/firmware#819 firmware: vc_image: Remove structure definition duplication firmware: vc_image/mmal/il/isp: Add support for 16bit/component YUV420 and YUVUV firmware: vcdbg: Don't use dma when file provided firmware: rtos: Avoid sleeping delay when RTOS is not present firmware: bootcode: Remove reliance on scanf to reduce bootcode.bin size firmware: bootcode: Changes to force to full speed firmware: bootcode: Make sure bootcode drops out firmware: bootcode: Mass storage changes to power off/on USB block firmware: bootcode: Change USB 1.1 to have 64 byte endpoints firmware: bootcode: Set MSD serial number to be the Pi serial number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a module parameter (defaulting to ignored) that clamps the polling rate
of high-speed Interrupt endpoints to a minimum microframe interval.
The parameter is modifiable at runtime as it is used when activating new
endpoints (such as on device connect).
Related: #2023