-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional overrides to rotary-encoder overlay #2334
Conversation
I've removed the trailing whitespace, but now your overlay seems to be knobless. |
Darn! I guess I should change "knob" to "rotary0"? |
Or vice versa - as long as everything agrees it doesn't matter. |
You also need to think about the types of the properties you are applying the overrides to - currently all the new parameters are declared to target strings. |
2e6f0b4
to
47471dc
Compare
@pelwell ok fixed that issue. about the other thing you have mentioned - i am not entirely sure what you mean. do i need to set the default values up in |
Although Device Tree contains no real type information - once compiled it is all just arrays of bytes - properties can be written as strings or arrays of integers of various sizes. Device drivers reading the properties then place an interpretation on those arrays of bytes, usually one that matches the way the property was written in the first place but not necessarily so. The DT parameter documentation describes the various parameter types and how to declare them. The new properties are mainly integers, but there is a boolean property which is true if it exists and false if it doesn't. |
i guess linux,axis, steps, steps-per-period need to have For rotary-encoder,relative-axis - that one doesn't appear to have anything with it? It seems as if the driver "defaults" to an absolute axis but then changes to relative if you declare it? So should I remove that from the and there is the wakeup-source one which is boolean - does that work the same that if declared it is true and if not declared anywhere it is false? The rotary-encoder,rollover one seems to be the same also |
I think it is good practice to put the default property values explicitly into the fragments, for ease of understanding and to protect against a change in the driver's defaults - except for false booleans... |
is there a way to check if the booleans default to false? it seems from the txt file I linked to above that they are all false, but I just wondered for future? |
I was going to say that there's no easy way, and that I'd read the source (which I had), but it's obvious that booleans have to default (in the driver at least) to false, otherwise you can't distinguish an explicit override from leaving it at the default. What we choose to make the overlay default value is up to us. |
ok updated - how does that look? |
Hold on - spotted some errors already....one minute and I will fix!! |
ok - take a look now |
I think you forgot to push - the errors I'm expecting you to fix are that boolean properties are referred to as "wakeup-source?" not "wakeup-source:?". |
While PRs are under development it is often better to keep updates as separate commits so it is clear what has changed at each step. GitHub allows changes to be viewed by commit or by file, which effectively squashes them to see the sum of all changes, and multiple commits can be squashed at merge time. |
ok, have removed the colons now |
Merged - thanks. |
great, thanks :-) |
kernel: Add additional overrides to rotary-encoder overlay See: raspberrypi/linux#2334 kernel: An overlay that allows a Linux key to be bound to a GPIO See: raspberrypi/linux#2329 firmware: dtoverlay app: Keep overlay symbols private firmware: dtoverlay app: Report unknown parameters in help firmware: IL ISP: Remove DPCM10_8 compressed input firmware: mmal_il: Add missing mappings for 8 bit Bayer encodings firmware: IMX219 tuning: enable motion detection firmware: IL camera: increase minimum resolution to 32x32 firmware: audioplus: hdmi: Remove spamming logging message firmware: tidy: Platform cull
kernel: Add additional overrides to rotary-encoder overlay See: raspberrypi/linux#2334 kernel: An overlay that allows a Linux key to be bound to a GPIO See: raspberrypi/linux#2329 firmware: dtoverlay app: Keep overlay symbols private firmware: dtoverlay app: Report unknown parameters in help firmware: IL ISP: Remove DPCM10_8 compressed input firmware: mmal_il: Add missing mappings for 8 bit Bayer encodings firmware: IMX219 tuning: enable motion detection firmware: IL camera: increase minimum resolution to 32x32 firmware: audioplus: hdmi: Remove spamming logging message firmware: tidy: Platform cull
Updates to the rotary-encoder overlay to add additional overrides that are possible according to this doc - https://elixir.free-electrons.com/linux/latest/source/Documentation/devicetree/bindings/input/rotary-encoder.txt
See #2331 for more details also