Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to export the pin used by the gpio-poweroff driver #2552

Merged
merged 3 commits into from
May 13, 2018

Conversation

nick-bulleid
Copy link
Contributor

If the GPIO line is configured to be an input, or for diagnostic purposes, it would be useful to examine the state of the GPIO line from userspace. This change allows this by exporting the GPIO line to sysfs.

@pelwell
Copy link
Contributor

pelwell commented May 12, 2018

That's neat. Could you:

  1. fix the indentation of the export parameter (use TABs not spaces to match the rest of it),
  2. add the export parameter to the overlays README,
  3. arrange the changes into three commits - driver, bindings document, and overlay+README - including a "Signed-off-by:" line (git commit -s, and git push -f to update the PR)?

The first two of those commits (not the overlay) could then be submitted upstream, but I'll accept it here in the meantime.

Signed-off-by: Nick Bulleid <nedbulleid@fastmail.com>
Signed-off-by: Nick Bulleid <nedbulleid@fastmail.com>
Signed-off-by: Nick Bulleid <nedbulleid@fastmail.com>
@nick-bulleid
Copy link
Contributor Author

That's neat.

Thanks!

I've made the changes you suggested.

@pelwell pelwell merged commit 30eb4e1 into raspberrypi:rpi-4.14.y May 13, 2018
popcornmix added a commit to raspberrypi/firmware that referenced this pull request May 18, 2018
kernel: firmware/raspberrypi: Notify firmware of a reboot
See: #968

kernel: config: Add CONFIG_DM_CACHE
See: raspberrypi/linux#2553

kernel: Cleanup of bcm2708_fb file to kernel coding standards

kernel: Add ability to export the pin used by the gpio-poweroff driver
See: raspberrypi/linux#2552

kernel: Revert: Sets the BCDC priority to constant 0

firmware: vc_image: vc_image_fill_yuv_uv sometimes overfilled the first column
See: raspberrypi/userland#465

firmware: arm_loader: Add SET_NOTIFY_REBOOT message
See: #968

firmware: gencmd: Report temperature with read_ring_osc values
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request May 18, 2018
kernel: firmware/raspberrypi: Notify firmware of a reboot
See: raspberrypi/firmware#968

kernel: config: Add CONFIG_DM_CACHE
See: raspberrypi/linux#2553

kernel: Cleanup of bcm2708_fb file to kernel coding standards

kernel: Add ability to export the pin used by the gpio-poweroff driver
See: raspberrypi/linux#2552

kernel: Revert: Sets the BCDC priority to constant 0

firmware: vc_image: vc_image_fill_yuv_uv sometimes overfilled the first column
See: raspberrypi/userland#465

firmware: arm_loader: Add SET_NOTIFY_REBOOT message
See: raspberrypi/firmware#968

firmware: gencmd: Report temperature with read_ring_osc values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants