sound: pcm512x-codec: Adding 352.8kHz samplerate support #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clivem You tried to upstream this patch years ago. What happened to it? |
|
@pelwell Not sure about that specific patch. I gave up submitting any audio patches to upstream. That codec one might not have even been submitted. I have a vague recollection of trying to get the sample rate increased on the Pi I2S driver first..... IIRC, submitted that in '16. It was ignored at the time, even though Eric Anholt added a Reviewed-by, and it wasn't until over a year later that Matthias Reichl re-submitted it with his name on it and Mark King accepted it. In the meantime, for other reasons I lost all interest in audio on Pi. |
|
Thanks, Clive. I'll have another go at pushing it, but until then we can accept it here. |
|
Great. Thx. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 28, 2019
kernel rpi-4.19.y changes for common DTS+overlays kernel: Cherrypick important w1 fixes See: raspberrypi/linux#2958 kernel: usb: dwc_otg: Clean up interrupt claiming code See: raspberrypi/linux#2612 kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard See: raspberrypi/linux#2923 kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support See: raspberrypi/linux#2975 kernel: configs: Enable PIDs cgroup See: raspberrypi/linux#2968
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
May 28, 2019
kernel rpi-4.19.y changes for common DTS+overlays kernel: Cherrypick important w1 fixes See: raspberrypi/linux#2958 kernel: usb: dwc_otg: Clean up interrupt claiming code See: raspberrypi/linux#2612 kernel: ASoC: decommissioning driver for 3Dlab Nano soundcard See: raspberrypi/linux#2923 kernel: sound: pcm512x-codec: Adding 352.8kHz samplerate support See: raspberrypi/linux#2975 kernel: configs: Enable PIDs cgroup See: raspberrypi/linux#2968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
352.8kHz support can be added to the pcm512c-codec.
This patch is around for years and usually gets applied in custom kernels (e.g. piCoreplayer).
It allows to convert DoP-128 straight to 352.8kHz PCM.
And it also allows synchronous upsampling from x*44.1, mainly to bypass the internal DSP.
The datasheet doesn't show that 352.8kHz is supported. That's why it is probably missing in the codec.