xhci: add quirk for host controllers that don't update endpoint DCS #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just compiled and installed your branch on my RPi 4 – no issues on tvheadend (rtl2832u dongle) nor weird messages in dmesg so far. Thank you! |
pelwell
reviewed
Jul 11, 2019
JamesH65
reviewed
Jul 11, 2019
|
All good here. This quirk patch fixes the RTL2832U problems. Tried all the various SDR tools and no errors. |
Seen on a VLI VL805 PCIe to USB controller. For non-stream endpoints at least, if the xHC halts on a particular TRB due to an error then the DCS field in the Out Endpoint Context maintained by the hardware is not updated with the current cycle state. Using the quirk XHCI_EP_CTX_BROKEN_DCS and instead fetch the DCS bit from the TRB that the xHC stopped on. See: raspberrypi#3060 Signed-off-by: Jonathan Bell <jonathan@raspberrypi.org>
|
Cheers anyone know how to fix RPI4 running buster where the /dev/ttyACM0 is missing, AMA0 and USB0 do work. Have critical RPI3 app that requires /dev/ttyACM0 and no access to source. Any viable work arounds. Thanks J |
|
This has nothing to do with this commit. Issues unrelated to the linux kernel should be posted on the community forum at https://www.raspberrypi.org/forum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen on a VLI VL805 PCIe to USB controller. For non-stream endpoints
at least, if the xHC halts on a particular TRB due to an error then
the DCS field in the Out Endpoint Context maintained by the hardware
is not updated with the current cycle state.
Using the quirk XHCI_EP_CTX_BROKEN_DCS and instead fetch the DCS bit
from the TRB that the xHC stopped on.
See: #3060
Signed-off-by: Jonathan Bell jonathan@raspberrypi.org