Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds LED OFF feature to HiFiBerry DAC+ADC sound card #3435

Merged
merged 1 commit into from
Jan 27, 2020
Merged

adds LED OFF feature to HiFiBerry DAC+ADC sound card #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions arch/arm/boot/dts/overlays/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,8 @@ Params: 24db_digital_gain Allow gain to be applied via the PCM512x codec
that does not result in clipping/distortion!)
slave Force DAC+ Pro into slave mode, using Pi as
master for bit clock and frame clock.
leds_off If set to 'true' the onboard indicator LEDs
are switched off at all times.


Name: hifiberry-dacplusadcpro
Expand Down
1 change: 1 addition & 0 deletions arch/arm/boot/dts/overlays/hifiberry-dacplusadc-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,6 @@
24db_digital_gain =
<&hifiberry_dacplusadc>,"hifiberry,24db_digital_gain?";
slave = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,slave?";
leds_off = <&hifiberry_dacplusadc>,"hifiberry-dacplusadc,leds_off?";
};
};
10 changes: 9 additions & 1 deletion sound/soc/bcm/hifiberry_dacplusadc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ struct pcm512x_priv {
static bool slave;
static bool snd_rpi_hifiberry_is_dacpro;
static bool digital_gain_0db_limit = true;
static bool leds_off;

static void snd_rpi_hifiberry_dacplusadc_select_clk(struct snd_soc_component *component,
int clk_id)
Expand Down Expand Up @@ -175,7 +176,10 @@ static int snd_rpi_hifiberry_dacplusadc_init(struct snd_soc_pcm_runtime *rtd)

snd_soc_component_update_bits(component, PCM512x_GPIO_EN, 0x08, 0x08);
snd_soc_component_update_bits(component, PCM512x_GPIO_OUTPUT_4, 0x0f, 0x02);
snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x08);
if (leds_off)
snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x00);
else
snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1, 0x08, 0x08);

if (digital_gain_0db_limit) {
int ret;
Expand Down Expand Up @@ -256,6 +260,8 @@ static int snd_rpi_hifiberry_dacplusadc_startup(
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_component *component = rtd->codec_dai->component;

if (leds_off)
return 0;
snd_soc_component_update_bits(component, PCM512x_GPIO_CONTROL_1,
0x08, 0x08);
hifiberry_dacplusadc_LED_cnt++;
Expand Down Expand Up @@ -347,6 +353,8 @@ static int snd_rpi_hifiberry_dacplusadc_probe(struct platform_device *pdev)
pdev->dev.of_node, "hifiberry,24db_digital_gain");
slave = of_property_read_bool(pdev->dev.of_node,
"hifiberry-dacplusadc,slave");
leds_off = of_property_read_bool(pdev->dev.of_node,
"hifiberry-dacplusadc,leds_off");

ret = devm_snd_soc_register_card(&pdev->dev,
&snd_rpi_hifiberry_dacplusadc);
Expand Down