component: Silence bind error on -EPROBE_DEFER #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acked by me. |
pelwell
requested changes
Apr 11, 2020
|
Upstream submission for reference https://patchwork.kernel.org/patch/11483959/. |
If a component fails to bind due to -EPROBE_DEFER we should not log an error as this is not a real failure. Fixes: vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517 vc4-drm soc:gpu: master bind failed: -517 Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
jameshilliard
force-pushed
the
component-defer
branch
from
9ea049c to
d4998ac
Compare
|
Thanks. |
|
C doesn't distinguish between spaces, TABs and newlines, so splitting a statement across multiple lines makes no difference. Braces would be needed if there were two statements within the body of the if. |
|
Ah, probably mixed that up since I mostly write Python code day to day. |
|
Upstream v2 patch with braces removed https://patchwork.kernel.org/patch/11484225/. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 17, 2020
kernel: configs: Add AUDIOINJECTOR_ISOLATED for Pi3 64-bit kernel: overlays: Fix dtc warnings in i2c-gpio kernel: media: rc: IR signal for Panasonic air conditioner too long kernel: sound:soc:codecs:ma120x0p.c update and added to defconfigs See: raspberrypi/linux#3534 kernel: drm/vc4: hdmi: Silence pixel clock error on -EPROBE_DEFER See: raspberrypi/linux#3538 kernel: component: Silence bind error on -EPROBE_DEFER See: raspberrypi/linux#3539 kernel: Fixes a problem with clock settings of HiFiBerry DAC+ADC PRO See: raspberrypi/linux#3545 kernel: ARM: dts: Extend SCB bus address range kernel: dts: bcm2711: Move emmc2 to its own bus kernel: dts: bcm2711: Restore emmc2 regulator, brokencd
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Apr 17, 2020
kernel: configs: Add AUDIOINJECTOR_ISOLATED for Pi3 64-bit kernel: overlays: Fix dtc warnings in i2c-gpio kernel: media: rc: IR signal for Panasonic air conditioner too long kernel: sound:soc:codecs:ma120x0p.c update and added to defconfigs See: raspberrypi/linux#3534 kernel: drm/vc4: hdmi: Silence pixel clock error on -EPROBE_DEFER See: raspberrypi/linux#3538 kernel: component: Silence bind error on -EPROBE_DEFER See: raspberrypi/linux#3539 kernel: Fixes a problem with clock settings of HiFiBerry DAC+ADC PRO See: raspberrypi/linux#3545 kernel: ARM: dts: Extend SCB bus address range kernel: dts: bcm2711: Move emmc2 to its own bus kernel: dts: bcm2711: Restore emmc2 regulator, brokencd
|
This has now landed upstream FYI. |
|
We noticed, thanks. rpi-5.7.y doesn't include your downstream patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a component fails to bind due to -EPROBE_DEFER we should not log an error as this is not a real failure.
Fixes:
Partial fix for #3513.