Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configs: Enable CONFIG_MEDIA_CEC_RC #4109

Merged
merged 1 commit into from
Feb 1, 2021
Merged

configs: Enable CONFIG_MEDIA_CEC_RC #4109

merged 1 commit into from
Feb 1, 2021

Conversation

popcornmix
Copy link
Collaborator

@popcornmix
Copy link
Collaborator Author

Note: these options were already enabled for arm64.

@popcornmix
Copy link
Collaborator Author

@PaulWebster has tested this.

@6by9
Copy link
Contributor

6by9 commented Feb 1, 2021

LGTM.
There is the question as to how useful DRM/KMS is on Pi0/1, and even more so using the GL drivers, but there's nothing fundamental against providing the option of loading them.

@popcornmix
Copy link
Collaborator Author

We've always had DRM/KMS enabled (as module) in Pi0/1, so this just enables a trivial amount of cec code.
Does anyone use it on Pi0/1? Not for desktop use I suspect but it could be used for standalone apps.

We did build LibreELEC using kms for Pi1 and the GUI wasn't unusable but it just ends up using too much RAM before long.
Something simpler should be possible. But it's an interesting question whether anyone is actually using kms on Pi0/1.

@pelwell
Copy link
Contributor

pelwell commented Feb 1, 2021

MEDIA_CEC_RC was not set in the 64-bit defconfigs and is not set after this PR is merged.

@popcornmix
Copy link
Collaborator Author

My mistake. Added to arm64 now.

@pelwell pelwell merged commit 61ff6df into raspberrypi:rpi-5.10.y Feb 1, 2021
@popcornmix popcornmix deleted the media_cec_rc branch February 1, 2021 14:31
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 5, 2021
@popcornmix
kernel: Bump to 5.10.13
7d91570 
kernel: configs: Enable CONFIG_MEDIA_CEC_RC
See: raspberrypi/linux#4109

kernel: Hifiberry DAC+ driver addition to support Hifiberry AMP100
See: raspberrypi/linux#4102

kernel: ARM: dts: Declare Pi400 and CM4 have no audio pins
See: https://www.raspberrypi.org/forums/viewtopic.php?f=98&t=301891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@popcornmix @6by9 @pelwell