drm/vc4: Notify firmware when use of simple framebuffer is complete #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The raspberrypi,firmware property has been documented as required in the binding but was never actually used in the final version of the binding. Remove it. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
The vc4 driver will need to tell the firmware that it takes over the display for the firmware to free its resources (lower the clock, free some memory, etc.) Let's add an optional phandle to our firmware node. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
|
@mripard this tested okay for me with LibreELEC on Pi3 and Pi4 with "ARM FB" allocation removed from |
|
Testing on LibreELEC / RPi4 was fine here as well, core clock boost and framebuffer allocations were removed as expected |
The RPI_FIRMWARE_NOTIFY_DISPLAY_DONE firmware call allows to tell the firmware the kernel is in charge of the display now and the firmware can free whatever resources it was using. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer functionnal. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
popcornmix
force-pushed
the
firmware-notify-done
branch
from
04d5f7f to
0805ea9
Compare
pelwell
reviewed
Jun 30, 2021
Once the call to drm_fb_helper_remove_conflicting_framebuffers() has been made, simplefb has been unregistered and the KMS driver is entirely in charge of the display. Thus, we can notify the firmware it can free whatever resource it was using to maintain simplefb functional. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Add the firmware phandle to the vc4 node so that we can send it the message that we're done with the firmware display. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
popcornmix
force-pushed
the
firmware-notify-done
branch
from
0805ea9 to
6ce13aa
Compare
|
Yep, it looks great, thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 2, 2021
…mplete See: raspberrypi/linux#4421 kernel: Fix CPU hang when using CEC while HDMI output is disabled See: raspberrypi/linux#4418 kernel: drm/vc4: hdmi: Add missing clk_disable_unprepare on error path See: raspberrypi/linux#4426 kernel: staging: vc04_services: isp: Set the YUV420/YVU420 format stride to 64 bytes See: raspberrypi/linux#4419 kernel: media: i2c: imx477: Add support for imx378 as a compatible sensor See: raspberrypi/linux#4420
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jul 2, 2021
…mplete See: raspberrypi/linux#4421 kernel: Fix CPU hang when using CEC while HDMI output is disabled See: raspberrypi/linux#4418 kernel: drm/vc4: hdmi: Add missing clk_disable_unprepare on error path See: raspberrypi/linux#4426 kernel: staging: vc04_services: isp: Set the YUV420/YVU420 format stride to 64 bytes See: raspberrypi/linux#4419 kernel: media: i2c: imx477: Add support for imx378 as a compatible sensor See: raspberrypi/linux#4420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest firmware and this call, the firmware is able to free the memory allocation for the simple framebuffer that was used in initial booting. This can be up to 16MB of gpu memory when running with
hdmi_enable_4kp60=1.It also allows the firmware to release the boost to the core clock that was necessary when driving that hdmi mode, and may no longer be required if kms choosing a lower resolution hdmi mode.