-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify overlay and add driver for Chipdip DAC #4476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some cosmetic (whitespace) issues, but basically this looks fine. Please fix the whitespace, then squash the changes to make three commits:
- The driver and its Makefile and Kconfig changes.
- The overlay and its Makefile and README changes.
- The updated _defconfig files with "SND_BCM2708_SOC_CHIPDIP_DAC=m" (you can grab this from here: pelwell@2476771)
Phil, thanks for the review, corrections have been made. |
The driver C file has ended up with DOS line endings (CR+LF), whereas Linux line endings should be just LF. Also, delete any trailing whitespace. Once you've done that, squash the commits down to the three I described above. |
I've fixed up the commits for you. Write three commit messages here in code sections - like this:
I can graft them on and merge the PR. |
Thank you. I am not sure I understand what I shall do. Please correct me if something is wrong.
|
Simple card fragment removed, GPIO fragment added. Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
Driver chipdip-dac.c added into sound/soc/bcm/, files sound/soc/bcm/Kconfig and sound/soc/bcm/Makefile updated. Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
Enable the driver for the ChipDip DAC soundcard. Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
That's perfect. I'm guessing that either you are using the GitHub GUI for creating your pull requests or you haven't discovered |
Thank you! |
See: raspberrypi/linux#4478 kernel: Modify overlay and add driver for Chipdip DAC See: raspberrypi/linux#4476 kernel: ARM: dts: Correct CM4 PHY MDIO address kernel: brcmfmac: Try product-specific clm_blob names first See: raspberrypi/linux#4469 kernel: overlays: Set CMA to 512MB on Pi 4 for vc4
See: raspberrypi/linux#4478 kernel: Modify overlay and add driver for Chipdip DAC See: raspberrypi/linux#4476 kernel: ARM: dts: Correct CM4 PHY MDIO address kernel: brcmfmac: Try product-specific clm_blob names first See: raspberrypi/linux#4469 kernel: overlays: Set CMA to 512MB on Pi 4 for vc4
The overlay has been changed and driver has been added for Chipdip DAC, tested on Raspberry PI3.