Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify overlay and add driver for Chipdip DAC #4476

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Modify overlay and add driver for Chipdip DAC #4476

merged 3 commits into from
Jul 27, 2021

Conversation

chipdipru
Copy link

The overlay has been changed and driver has been added for Chipdip DAC, tested on Raspberry PI3.

Copy link
Contributor

@pelwell pelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some cosmetic (whitespace) issues, but basically this looks fine. Please fix the whitespace, then squash the changes to make three commits:

  1. The driver and its Makefile and Kconfig changes.
  2. The overlay and its Makefile and README changes.
  3. The updated _defconfig files with "SND_BCM2708_SOC_CHIPDIP_DAC=m" (you can grab this from here: pelwell@2476771)

sound/soc/bcm/chipdip-dac.c Outdated Show resolved Hide resolved
sound/soc/bcm/chipdip-dac.c Outdated Show resolved Hide resolved
@chipdipru
Copy link
Author

Phil, thanks for the review, corrections have been made.

@pelwell
Copy link
Contributor

pelwell commented Jul 26, 2021

The driver C file has ended up with DOS line endings (CR+LF), whereas Linux line endings should be just LF. Also, delete any trailing whitespace.

Once you've done that, squash the commits down to the three I described above.

@pelwell
Copy link
Contributor

pelwell commented Jul 26, 2021

I've fixed up the commits for you. Write three commit messages here in code sections - like this:

First commit message

This is the first commit.

Signed-off-by: User Name <user@email.com>

I can graft them on and merge the PR.

@chipdipru
Copy link
Author

chipdipru commented Jul 27, 2021

Thank you. I am not sure I understand what I shall do. Please correct me if something is wrong.

Update and rename chipdip-i2s-master-dac-overlay

Simple card fragment removed, GPIO fragment added.

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>

Add chipdip-dac driver

Driver chipdip-dac.c added into sound/soc/bcm/, files sound/soc/bcm/Kconfig and sound/soc/bcm/Makefile updated

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>

Update _defconfig files

Files arch/arm/configs/bcm2709_defconfig, arch/arm/configs/bcm2711_defconfig, arch/arm/configs/bcmrpi_defconfig, arch/arm64/configs/bcm2711_defconfig, arch/arm64/configs/bcmrpi3_defconfig updated.

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>

Simple card fragment removed, GPIO fragment added.

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
Driver chipdip-dac.c added into sound/soc/bcm/, files
sound/soc/bcm/Kconfig and sound/soc/bcm/Makefile updated.

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
Enable the driver for the ChipDip DAC soundcard.

Signed-off-by: Evgenij Sapunov <evgenij.sapunov@chipdip.ru>
@pelwell
Copy link
Contributor

pelwell commented Jul 27, 2021

That's perfect.

I'm guessing that either you are using the GitHub GUI for creating your pull requests or you haven't discovered git rebase -i. I recommend taking the time to learn how to edit and squash commits, then using git push -f to update the branch you created your PR from until it looks correct - it will save you a lot of time in the future.

@pelwell pelwell merged commit 86729e7 into raspberrypi:rpi-5.10.y Jul 27, 2021
@chipdipru
Copy link
Author

Thank you!

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jul 27, 2021
See: raspberrypi/linux#4478

kernel: Modify overlay and add driver for Chipdip DAC
See: raspberrypi/linux#4476

kernel: ARM: dts: Correct CM4 PHY MDIO address

kernel: brcmfmac: Try product-specific clm_blob names first
See: raspberrypi/linux#4469

kernel: overlays: Set CMA to 512MB on Pi 4 for vc4
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Jul 27, 2021
See: raspberrypi/linux#4478

kernel: Modify overlay and add driver for Chipdip DAC
See: raspberrypi/linux#4476

kernel: ARM: dts: Correct CM4 PHY MDIO address

kernel: brcmfmac: Try product-specific clm_blob names first
See: raspberrypi/linux#4469

kernel: overlays: Set CMA to 512MB on Pi 4 for vc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants