Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpi 5.10.y imx477 fstrobe #4621

Closed

Conversation

cnelson-01
Copy link

Adds "call for strobe" settings to the v4l2-ctrls. The idea being that the camera can output a strobe signal which then can be used by an illuminator eg V4L2_CID_FLASH...

Implements the camera strobe control signals for the imx477

Couple things to check:

  • What are the limits on width and delay?
  • is setting FLASH_TRIG_RS to 0 the correct way to disable the fstrobe? I did some basic testing and it seems to work.

…t the camera can output a strobe signal which then can be used by an illuminator eg V4L2_CID_FLASH...

Implements the camera strobe control signals for the imx477
V4L2_CID_CAMERA_STROBE_MODE
V4L2_CID_CAMERA_STROBE_WIDTH
V4L2_CID_CAMERA_STROBE_DELAY

These controls allow for controlling a cameras strobe signal.
@6by9
Copy link
Contributor

6by9 commented Oct 8, 2021

Thank you for creating a PR for this - it is appreciated.

Creating extra V4L2 controls is something that isn't sustainable in a downstream kernel as we'll then get conflicts when mainline add their next one as we have in #4440.
The only option is to get the controls added to the mainline Linux kernel via the linux-media tree, and we'll then backport. In the meantime module parameters are the only solution.

@cnelson-01
Copy link
Author

Makes sense. I'll modify this pull to remove the v4l2 changes and see if I can get the camera strobe features added to the linux media tree.

@cnelson-01 cnelson-01 closed this Oct 9, 2021
@jakekake
Copy link

What will be the easiest way to get fstrobe working with libcamera on a 5.15.y kernel version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants