ARM: dts: Permanently disable hdmi1 and ddc1 on CM4S #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Phil! |
|
Shouldn't this change be in |
|
Indeed - the dangers of TAB completion. |
pelwell
changed the title
|
I tried this and it seemed to fix the error in vcdbg log. 004891.079: brfs: File read: /mfs/sd/overlays/vc4-kms-v3d-pi4.dtbo |
|
Thanks for the fix! This solves #4857 (kms driver). With fkms/legacy #4858 the VC still tries to use hdmi1: kernel vcdbg |
|
It's mentioned in the PR description, that's why I stated it |
CM4S has no HDMI1 output, so it is advisable to disable the controller and its I2C interface in software. This is ordinarily done by setting their status properties to "disabled", but the vc4-kms-v3d(-pi4) overlay enables both HDMIs and DDCs as part of the transfer of control from the VPU. Knobble the CM4S dts in such a way that the overlay applies successfully but the hdmi1 and ddc1 nodes remain disabled by changing the compatible string to something unrecognised. See: raspberrypi#4857 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
Not any more it isn't. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 4, 2022
See: raspberrypi/linux#4867 kernel: Add Support for Geekworm MZP280 in vc4-dpi-panel-overlay See: raspberrypi/linux#4868 kernel: dtoverlay: Reduce size of PCIE IB window in pcie-32-dma overlay See: raspberrypi/linux#4870 kernel: ARM: dts: Permanently disable hdmi1 and ddc1 on CM4S See: raspberrypi/linux#4869 kernel: dtoverlays: Correct field sizes in pcie-32bit-dma See: raspberrypi/linux#4871
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 4, 2022
See: raspberrypi/linux#4867 kernel: Add Support for Geekworm MZP280 in vc4-dpi-panel-overlay See: raspberrypi/linux#4868 kernel: dtoverlay: Reduce size of PCIE IB window in pcie-32-dma overlay See: raspberrypi/linux#4870 kernel: ARM: dts: Permanently disable hdmi1 and ddc1 on CM4S See: raspberrypi/linux#4869 kernel: dtoverlays: Correct field sizes in pcie-32bit-dma See: raspberrypi/linux#4871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM4S has no HDMI1 output, so it is advisable to disable the controller
and its I2C interface in software. This is ordinarily done by setting
their status properties to "disabled", but the vc4-kms-v3d(-pi4)
overlay enables both HDMIs and DDCs as part of the transfer of control
from the VPU.
Knobble the CM4S dts in such a way that the overlay applies
successfully but the hdmi1 and ddc1 nodes remain disabled by changing
the compatible string to something unrecognised.
See: #4857
Signed-off-by: Phil Elwell phil@raspberrypi.com