brcmfmac: Fix 802.1x #5973
Merged
brcmfmac: Fix 802.1x #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7d239fb broke 802.1X authentication by setting profile->use_fwsup = NONE whenever PSK is not used. However 802.1X does not use PSK and requires profile->use_fwsup set to 1X, or brcmf_cfg80211_set_pmk() fails. Fix this by checking that profile->use_fwsup is not already set to 1X and avoid setting it to NONE in that case. Fixes: 7d239fb (brcmfmac: Fix interoperating DPP and other encryption network access) Fixes: raspberrypi#5964
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 21, 2024
See: raspberrypi/linux#5974 kernel: brcmfmac: Fix 802.1x See: raspberrypi/linux#5973 kernel: Add IQaudio CodecZero to hat_map.dts See: raspberrypi/linux#5972 kernel: arm64/Kconfig: Don't set DMA_BOUNCE_UNALIGNED_KMALLOC See: raspberrypi/linux#5975
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 21, 2024
See: raspberrypi/linux#5974 kernel: brcmfmac: Fix 802.1x See: raspberrypi/linux#5973 kernel: Add IQaudio CodecZero to hat_map.dts See: raspberrypi/linux#5972 kernel: arm64/Kconfig: Don't set DMA_BOUNCE_UNALIGNED_KMALLOC See: raspberrypi/linux#5975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7d239fb broke 802.1X authentication by setting profile->use_fwsup = NONE whenever PSK is not used. However 802.1X does not use PSK and requires profile->use_fwsup set to 1X, or brcmf_cfg80211_set_pmk() fails. Fix this by checking that profile->use_fwsup is not already set to 1X and avoid setting it to NONE in that case.
Fixes: 7d239fb (brcmfmac: Fix interoperating DPP and other encryption network access)
Fixes: #5964