dts: 2712: Reduce default cma usage on Pi5 #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant cma shouldn't really be needed on Pi5 as the hardware blocks support iommu and can access system memory. We've migrated codec and camera support to system memory, and 3d has always (even on Pi4) used system memory. A large cma block causes issues with enabling NUMA on a low memory (2G) Pi5, as cma cannot span numa regions. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
pelwell
reviewed
Sep 13, 2024
| @@ -3,7 +3,7 @@ | |||
| #include "cma-overlay.dts" | |||
|
|
|||
| &frag0 { | |||
| size = <((320-4)*1024*1024)>; | |||
| size = <(64*1024*1024)>; | |||
There was a problem hiding this comment.
The fact that this is a multiple of 64MB means it will not be automatically capped to the platform-limit, but this is way below all the limits so not an issue.
There was a problem hiding this comment.
Yes - I spent a while reading the firmware code and came to same conclusion.
|
I'll leave this here for a while to see if anyone has objections. I've tested dual 4k desktop use (with 3d active). |
|
Removed draft tag |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 10, 2024
kernel: dts: 2712: Reduce default cma usage on Pi5 See: raspberrypi/linux#6361 kernel: drm/v3d,vc4: Stop the active perfmon before being destroyed See: raspberrypi/linux#6401 kernel: mmc: sd: disable sd cqhci by default See: raspberrypi/linux#6405 kernel: drm/vc4: Rework UPM allocation to avoid double buffering See: raspberrypi/linux#6385 kernel: dts: bcm2712d0: Add non-d0 vc6 compatible string See: raspberrypi/linux#6408
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 10, 2024
kernel: dts: 2712: Reduce default cma usage on Pi5 See: raspberrypi/linux#6361 kernel: drm/v3d,vc4: Stop the active perfmon before being destroyed See: raspberrypi/linux#6401 kernel: mmc: sd: disable sd cqhci by default See: raspberrypi/linux#6405 kernel: drm/vc4: Rework UPM allocation to avoid double buffering See: raspberrypi/linux#6385 kernel: dts: bcm2712d0: Add non-d0 vc6 compatible string See: raspberrypi/linux#6408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant cma shouldn't really be needed on Pi5 as the hardware blocks support iommu and can access system memory.
We've migrated codec and camera support to system memory, and 3d has always (even on Pi4) used system memory.
A large cma block causes issues with enabling NUMA on a low memory (2G) Pi5, as cma cannot span numa regions.