Skip to content

Conversation

@foonerd
Copy link
Contributor

@foonerd foonerd commented Nov 20, 2024

The panel-ilitek-ili9881c.c which Touch Display 2 is based on already contains orientation.
By minor update to the vc4-kms-dsi-ili9881-7inch-overlay.dts panel can be rotated with minimal effort.

Issue opened here:
raspberrypi/documentation#3923

Complete discussion and working dbto in the community thread:
https://community.volumio.com/t/guide-official-raspberry-touch-display-2/69791

@6by9
Copy link
Contributor

6by9 commented Nov 20, 2024

Commits should include a commit text and Signed-off-by: line., but otherwise looks reasonable.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

@6by9
For my benefit, the commit line should be:
dtoverlays: Enable Raspberry Touch 2 rotation

Did I get this right?

Who should be listed as "Signed-off-by: "?

Copy link
Contributor

@6by9 6by9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: is documented in https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

It should match the commit author in this case. For upstream both would need use your real name rather than any nickname, but for dtoverlays that isn't as critical.

@6by9
Copy link
Contributor

6by9 commented Nov 20, 2024

The patches get applied to the tree exactly as they are presented in the PR. The 3 changes therefore want to get squashed into one, and force pushed (git push -f ... ) to your Github branch.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

I see. Lets close this PR and open another, correct one. - Do you agree?

@pelwell
Copy link
Contributor

pelwell commented Nov 20, 2024

No - if the end result is one patch then we can squash at the point of merging.

@foonerd
Copy link
Contributor Author

foonerd commented Nov 20, 2024

Thanks. In such case, is there anything else needed from me at this point?

@pelwell
Copy link
Contributor

pelwell commented Nov 20, 2024

I think we're good - I'll just give it the once over then merge.

@pelwell pelwell merged commit fa6ad4b into raspberrypi:rpi-6.6.y Nov 20, 2024
pelwell pushed a commit that referenced this pull request Nov 21, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
pelwell pushed a commit that referenced this pull request Nov 21, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Nov 25, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Nov 25, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Nov 25, 2024
kernel: media: i2c: imx477: Fix link frequency menu
See: raspberrypi/linux#6483

kernel: Adding Pimidi kernel module
See: raspberrypi/linux#6482

kernel: Enable Raspberry Touch 2 rotation with overlay
See: raspberrypi/linux#6480
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Nov 25, 2024
kernel: media: i2c: imx477: Fix link frequency menu
See: raspberrypi/linux#6483

kernel: Adding Pimidi kernel module
See: raspberrypi/linux#6482

kernel: Enable Raspberry Touch 2 rotation with overlay
See: raspberrypi/linux#6480
@harmjanr
Copy link

harmjanr commented Dec 1, 2024

Any clue when we can expect this PR / 6.6.63 via sudo apt full-upgrade?

@6by9
Copy link
Contributor

6by9 commented Dec 2, 2024

Any clue when we can expect this PR / 6.6.63 via sudo apt full-upgrade?

Unlikely to be before Christmas as we've just done a kernel release.

popcornmix pushed a commit that referenced this pull request Dec 7, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Dec 9, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Dec 10, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Dec 16, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Dec 16, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Dec 20, 2024
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Jan 2, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Jan 2, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Jan 6, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 10, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 10, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 17, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 17, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 19, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 24, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 24, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Feb 28, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
wanghao75 pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this pull request Mar 5, 2025
popcornmix pushed a commit that referenced this pull request Mar 10, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 10, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 13, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 13, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 24, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 25, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Mar 31, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Apr 7, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
popcornmix pushed a commit that referenced this pull request Apr 14, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
nmbath pushed a commit to victronenergy/linux that referenced this pull request Apr 22, 2025
popcornmix pushed a commit that referenced this pull request Apr 24, 2025
See: #6480
Signed-off-by: foonerd <foonerd@github.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 9, 2025
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 12, 2025
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 16, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 17, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 17, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 18, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 19, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
rajeshkumarwr pushed a commit to rajeshkumarwr/linux-yocto that referenced this pull request Jun 19, 2025
commit c0e5e0171a9e04030e80f160365cda5f37173f0f from
https://github.com/raspberrypi/linux.git rpi-6.12.y

See: raspberrypi/linux#6480
Signed-off-by: foonerd <foonerd@github.com>
Signed-off-by: Rajeshkumar Ramasamy <rajeshkumar.ramasamy@windriver.com>
ibfru pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this pull request Sep 26, 2025
ibfru pushed a commit to openeuler-mirror/raspberrypi-kernel that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants