Add driver for the Waveshare DSI-TOUCH series panels. #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
requested changes
Dec 28, 2024
| @@ -0,0 +1,306 @@ | |||
| // SPDX-License-Identifier: GPL-2.0 | |||
| /* | |||
| * Copyright (C) 2022 Raspberry Pi Ltd. | |||
| /* | ||
| * Copyright (C) 2022 Raspberry Pi Ltd. | ||
| * | ||
| * Based on rpi-panel-v2-regulator.c by Broadcom |
| @@ -0,0 +1,1353 @@ | |||
| // SPDX-License-Identifier: GPL-2.0 | |||
| /* | |||
| * Copyright © 2023 Raspberry Pi Ltd | |||
There was a problem hiding this comment.
Okay, this is a copy. I'll fix this.
Any other suggestions? I'll standardize the changes.
There was a problem hiding this comment.
Previously mentioned issues have been fixed. PTAL.
The regulator of the Waveshare DSI-TOUCH series panels is different. Add a new driver for this regulator. Signed-off-by: Waveshare_Team <support@waveshare.com>
|
Check the auto-build errors. And as a wider question, does this warrant a new driver? Are the devices so different from the v1s? |
…ries panels. the driver are provided for the Waveshare DSI-TOUCH series panels, modelled after the other Ilitek controller drivers, but not limited to Ilitek series controllers. The aim is to offer a more consistent operation and experience for the Waveshare DSI-TOUCH series panels. Signed-off-by: Waveshare_Team <support@waveshare.com>
added 2 commits
December 30, 2024 11:07
…vice Tree support. Add the device tree for the Waveshare DSI-TOUCH series panels. Signed-off-by: Waveshare_Team <support@waveshare.com>
Enable the Waveshare DSI-TOUCH series panel driver in the defconfig files that support the Pi5/Pi4/Pi3 family. Signed-off-by: Waveshare_Team <support@waveshare.com>
|
Yes, I think a new driver needs to be developed. v2 versions have significant architectural changes compared to the v1 series.
btw，The previous check auto-build errors has been resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, everyone:
This is the driver for the DSI-TOUCH series of panels to be released by Waveshare.
Regarding the missing help warning, it should be caused by the length of the help description being less than 4, so i think it allowed to ignore things.
If you have any other suggestions we'd be happy to make changes!