add mira220 image sensor #6717

fiepfiep · 2025-03-12T17:42:45Z

add driver / device tree support for ams mira220

needed changes also done for libcamera.

6by9

I've started to review this, but I'm noticing a lot of my comments from #6552 haven't been addressed.

If embedded data isn't required, then do not include it.

arch/arm/boot/dts/overlays/mira220-overlay.dts

6by9 · 2025-03-12T17:52:57Z

arch/arm/boot/dts/overlays/mira220.dtsi

+			data-lanes = <1 2>;
+			// clock-noncontinuous;
+			link-frequencies =
+				/bits/ 64 <456000000>;


Is this the correct link frequency for this sensor?

currently operating at 1.5 Gbit/s per lane

solved, set to 750, as datarate is 1500Mbit/s

6by9 · 2025-03-12T18:03:21Z

drivers/media/i2c/mira220.c

+
+ /* Embedded metadata stream structure */
+ #define MIRA220_EMBEDDED_LINE_WIDTH 16384
+ #define MIRA220_NUM_EMBEDDED_LINES 1


Does this sensor actually have useful embedded metadata? It's disabled in libcamera.

I'd made the same comment in #6552 (comment) that this isn't how mainline are implementing metadata, so it's simpler to not implement it in the driver if not needed.

I have removed the embedded data

6by9 · 2025-03-12T18:03:37Z

drivers/media/i2c/mira220.c

+ // 1600_1400_30fps_12b_2lanes
+
+ static const struct mira220_reg full_1600_1400_1500_12b_2lanes_reg[] = {
+	{0x1003,0x2}, //,Initial Upload


Comment isn't useful.

6by9 · 2025-03-12T18:12:11Z

drivers/media/i2c/mira220.c

+
+ // 1600_1400_30fps_12b_2lanes
+
+ static const struct mira220_reg full_1600_1400_1500_12b_2lanes_reg[] = {


You have about 18 registers that differ between these 3 huge tables. Break out all the common stuff into a common table, and only send the bits that change per mode

thanks, will do.

simplified, reduced driver to 1 mode only.

6by9 · 2025-03-12T18:12:59Z

drivers/media/i2c/mira220.c

+ #define MIRA220_PIXEL_ARRAY_WIDTH		1600U
+ #define MIRA220_PIXEL_ARRAY_HEIGHT		1400U
+
+ #define MIRA220_ANALOG_GAIN_REG			0x400A


Comment made at #6552 (comment) that the V4L2_CCI is preferred rather than bare register defines as it encodes the size of each register.

I converted everything to the new style cci writes

6by9 · 2025-03-12T18:14:43Z

drivers/media/i2c/mira220.c

+ static const char * const mira220_supply_name[] = {
+	 // TODO(jalv): Check supply names
+	 /* Supplies can be enabled in any order */
+	 "VANA",  /* Analog (2.8V) supply */


Regulators should be named in lower case.

pelwell · 2025-04-02T19:40:34Z

I'll warn you now that, once the content of these commits has been approved, the end result should ideally be 3 commits - driver changes, config changes, and overlay/README changes.

pelwell · 2025-04-02T19:49:18Z

arch/arm/boot/dts/overlays/mira220-overlay.dts

@@ -58,28 +58,6 @@
 		};
 	};

-	fragment@102 {


Did you delete this fragment by mistake? The media-controller parameter refers to it.

Yes that is a mistake.

I put it back. thanks for finding out.

fiepfiep · 2025-04-02T19:58:39Z

I'll warn you now that, once the content of these commits has been approved, the end result should ideally be 3 commits - driver changes, config changes, and overlay/README changes.

I will keep it in mind. Once all is approved by you I will refactor it to 3 commits.

fiepfiep · 2025-04-02T21:48:44Z

I cleaned up the driver a bit, implemented the new CCI_REG style writes, and took care of 6by9's comments.
Please let me know if you find other issues before we can do the merge.

pelwell

Apart from the extra blank lines in the README, the overlay looks good.

Checkpatch has lots of complaints about the driver which you should really fix. Nobody using printk directly anymore, for example.

The only additional change I would like (apart from refactoring down to 3 commits as discussed) is the addition of CONFIG_VIDEO_MIRA220 to the new PREEMPT_RT config file arm64/bcm2711_rt_defconfig.

pelwell · 2025-04-03T08:43:03Z

arch/arm/boot/dts/overlays/README

@@ -3632,6 +3649,7 @@ Params: rotation                Mounting rotation of the camera sensor (0 or
                                Appears not to work on Pi3.


+


This looks like an unnecessary change.

pelwell · 2025-04-03T08:44:47Z

arch/arm/boot/dts/overlays/README

@@ -3511,6 +3511,23 @@ Params:
                                (default 16).


+


2 blank lines is enough.

pelwell · 2025-04-03T08:47:17Z

arch/arm/boot/dts/overlays/README

+                                configuring the sensor (default on)
+        cam0                    Adopt the default configuration for CAM0 on a
+                                Compute Module (CSI0, i2c_vc, and cam0_reg).
+


6by9

Still a number of my previous review comments haven't been addressed.

Please remove the references to the embedded data pad.
Please remove all commented out code.
Please remove all redundant comments.
Please rationalise the logging messages. Very few should be needed at all.
Regulator names should be consistently in lower case.

6by9 · 2025-04-03T17:22:53Z

arch/arm/boot/dts/overlays/mira220-overlay.dts

+		       <&csi_frag>, "target:0=",<&csi0>,
+		       <&clk_frag>, "target:0=",<&cam0_clk>,
+		       <&cam_node>, "clocks:0=",<&cam0_clk>,
+		       <&cam_node>, "VANA-supply:0=",<&cam0_reg>;


Your supply is now vana-supply, so this won't match.

6by9 · 2025-04-03T17:24:47Z

drivers/media/i2c/Kconfig

@@ -149,6 +149,20 @@ config VIDEO_HI847
          To compile this driver as a module, choose M here: the
          module will be called hi847.

+config VIDEO_MIRA220


These are normally in alphabetical order. (I see the Arducam drivers have got out of position during forward porting).

Annoyingly this will also move the position in the defconfigs, so perhaps I don't care enough.

6by9 · 2025-04-03T17:25:11Z

drivers/media/i2c/Makefile

@@ -49,6 +49,7 @@ obj-$(CONFIG_VIDEO_HI556) += hi556.o
 obj-$(CONFIG_VIDEO_HI846) += hi846.o
 obj-$(CONFIG_VIDEO_HI847) += hi847.o
 obj-$(CONFIG_VIDEO_I2C) += video-i2c.o
+obj-$(CONFIG_VIDEO_MIRA220)	+= mira220.o


Ditto - alphabetical order please.

6by9 · 2025-04-03T17:27:10Z

drivers/media/i2c/mira220.c

+
+#define MIRA220_ANALOG_GAIN_MIN 1
+#define MIRA220_ANALOG_GAIN_MAX \
+	1 /* Fixed analog gain to 1, to avoid unexpected behavior. */


Weird line breaking. That does seem quite a limitation though if you have no analogue gain.

6by9 · 2025-04-03T17:28:24Z

drivers/media/i2c/mira220.c

+// Outdated. See below.
+// pixel_rate = link_freq * 2 * nr_of_lanes / bits_per_sample
+// 1.0Gb/s * 2 * 2 / 12 = 357913941
+// #define MIRA220_PIXEL_RATE		(357913941)


If it's outdated, then please remove it.

6by9 · 2025-04-03T17:41:00Z

drivers/media/i2c/mira220.c

+
+	/*test cci write*/
+	ret = cci_read(mira220->regmap, MIRA220_EXP_TIME_REG, &readval, &ret);
+	otherval = readval & 0xFFFF;


Why read the value before writing it? You do nothing with the result.

6by9 · 2025-04-03T17:44:01Z

drivers/media/i2c/mira220.c

+	if (mira220_check_hwcfg(dev))
+		return -EINVAL;
+
+	/* Parse device tree to check if dtoverlay has param skip-reg-upload=1 */


6by9 · 2025-04-03T17:44:49Z

drivers/media/i2c/mira220.c

+}
+
+static const struct dev_pm_ops mira220_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(mira220_suspend, mira220_resume)


You shouldn't be implementing SLEEP_OPS.

6by9 · 2025-04-03T17:46:38Z

drivers/media/i2c/mira220.c

+		SET_RUNTIME_PM_OPS(mira220_power_off, mira220_power_on, NULL)
+};
+
+static const struct of_device_id mira220_dt_ids[] = { { .compatible =


Please use the normal formatting for dt_ids.

static const struct of_device_id mira220_dt_ids[] = { { .compatible = "ams,mira220" }, { /* sentinel */ } };

6by9 · 2025-04-03T17:47:37Z

drivers/media/i2c/mira220.c

+MODULE_DEVICE_TABLE(of, mira220_dt_ids);
+
+static const struct i2c_device_id mira220_ids[] = { { "mira220", 0 }, {} };
+MODULE_DEVICE_TABLE(i2c, mira220_ids);


You shouldn't need I2C ids. This driver needs config data, so you can't load via sysfs.

pelwell · 2025-04-06T20:56:15Z

FYI the build checks explicitly set CONFIG_WERROR=y, overriding the defconfigs:

scripts/config --file ${{github.workspace}}/build/.config --set-val CONFIG_WERROR y

fiepfiep · 2025-04-15T13:26:45Z

@pelwell could you run your checks again? I split my changes into 3 commits as requested.

pelwell · 2025-04-15T13:52:45Z

It looks like somebody has started them. Please mark the PR as "Ready for review" when you think it is. However, there is no excuse for some of these (https://github.com/raspberrypi/linux/actions/runs/14470568709/job/40583365956?pr=6717#step:6:80) checkpatch errors such as trailing whitespace.

Adds defconfig for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

Adds an overlay for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

Adds a driver for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

6by9 requested changes Mar 12, 2025

View reviewed changes

popcornmix force-pushed the rpi-6.12.y branch from 28d1e43 to de1afd2 Compare March 13, 2025 14:14

popcornmix force-pushed the rpi-6.12.y branch from 617b6a8 to 8d53a07 Compare March 25, 2025 12:36

fiepfiep closed this Mar 27, 2025

fiepfiep force-pushed the rpi-6.12.y branch from 5321fb8 to cd231d4 Compare March 27, 2025 08:32

fiepfiep reopened this Apr 2, 2025

pelwell reviewed Apr 2, 2025

View reviewed changes

fiepfiep marked this pull request as draft April 2, 2025 19:57

fiepfiep force-pushed the rpi-6.12.y branch from 1ef53d1 to b9efe09 Compare April 2, 2025 21:38

fiepfiep requested a review from 6by9 April 2, 2025 21:43

fiepfiep marked this pull request as ready for review April 2, 2025 21:43

fiepfiep marked this pull request as draft April 2, 2025 21:44

fiepfiep force-pushed the rpi-6.12.y branch from 4181345 to e3242fc Compare April 2, 2025 22:15

pelwell reviewed Apr 3, 2025

View reviewed changes

6by9 reviewed Apr 3, 2025

View reviewed changes

6by9 mentioned this pull request Apr 15, 2025

Camera Stream error raspberrypi/libcamera#255

Open

fiepfiep force-pushed the rpi-6.12.y branch 2 times, most recently from 6c62034 to a0c3d9c Compare April 15, 2025 13:23

fiepfiep requested a review from 6by9 April 15, 2025 13:25

philippe baetens added 3 commits April 15, 2025 17:39

defconfigs: Add ams Mira220 image sensor to Pi defconfigs

d678328

Adds defconfig for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

dtoverlays: Add overlay for ams Mira220 image sensor

ce31776

Adds an overlay for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

media/i2c: Add driver for ams Mira220

59de12a

Adds a driver for the Mira220 1600x1400 global shutter image sensor Signed-off-by: Philippe Baetens <philippe.baetens@ams-osram.com>

fiepfiep force-pushed the rpi-6.12.y branch from a0c3d9c to 59de12a Compare April 15, 2025 15:40

fiepfiep marked this pull request as ready for review April 15, 2025 15:41


		// 1600_1400_30fps_12b_2lanes

		static const struct mira220_reg full_1600_1400_1500_12b_2lanes_reg[] = {

		@@ -3632,6 +3649,7 @@ Params: rotation Mounting rotation of the camera sensor (0 or
		Appears not to work on Pi3.

add mira220 image sensor #6717

Are you sure you want to change the base?

add mira220 image sensor #6717

Conversation

fiepfiep commented Mar 12, 2025 • edited Loading

6by9 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelwell commented Apr 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiepfiep commented Apr 2, 2025

fiepfiep commented Apr 2, 2025 • edited Loading

pelwell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

6by9 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelwell commented Apr 6, 2025

fiepfiep commented Apr 15, 2025

pelwell commented Apr 15, 2025

fiepfiep commented Mar 12, 2025 •

edited

Loading

fiepfiep commented Apr 2, 2025 •

edited

Loading

6by9 left a comment •

edited

Loading