-
Notifications
You must be signed in to change notification settings - Fork 908
Merge intern examples #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…23 Real Time Clock) New 150 — Add example for the PCF8523 Real Time Clock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
int main() { | ||
stdio_init_all(); | ||
#if !defined(i2c_default) || !defined(PICO_DEFAULT_I2C_SDA_PIN) || !defined(PICO_DEFAULT_I2C_SCL_PIN) | ||
#warning i2c/mpu6050_i2c example requires a board with I2C pins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should have said i2c/pa1010d_i2c
instead of i2c/mpu6050_i2c
?
i'm fine with that if they are effectively the same (modulo actually working!) |
Pick one to merge @kilograham when you merge, and then kill the other I guess! |
well which is the latest/greatest? also i saw I think that some half finished microphone example got merged? |
As it's a bigger PR number, I guess I can claim that #169 is the "latest", but I'm not going to claim that it's the "greatest". 😉 If you want to do the merge-rebasing yourself then feel free, and I can always create a separate PR for the
Yeah that was #148 🎤 Perhaps Alasdair got a bit carried away? 🤷♂️ |
closed in favor of #171 |
I have updated a couple of files per @kilograham requests, but I have not tested any of these changes. They look sane. So from my point of view I think this branch can be merged.