Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lis3dh_i2c: fix TEMP_CFG_REG address #483

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

602p
Copy link
Contributor

@602p 602p commented Mar 26, 2024

TEMP_CFG_REG is 0x1F, not 0xC0. I suspect this is just a typo since the value written to it is 0xC0.

See https://www.mouser.com/datasheet/2/389/lis3dh-1849589.pdf#[{%22num%22%3A141%2C%22gen%22%3A0}%2C{%22name%22%3A%22XYZ%22}%2C61%2C439%2Cnull] .

@peterharperuk
Copy link
Contributor

Thanks. Looks good

@peterharperuk peterharperuk added this to the 1.5.2 milestone Mar 27, 2024
@kilograham kilograham modified the milestones: 1.5.2, 2.0.1 Aug 20, 2024
@kilograham kilograham modified the milestones: 2.1.0, 2.1.1 Dec 5, 2024
peterharperuk
peterharperuk previously approved these changes Feb 5, 2025
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again. I don't have this device but the change looks correct when compared to the datasheet.

@peterharperuk peterharperuk changed the base branch from master to develop February 6, 2025 13:13
@peterharperuk peterharperuk dismissed their stale review February 6, 2025 13:13

The base branch was changed.

@peterharperuk
Copy link
Contributor

Ah - Switched to develop!

Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested now

@peterharperuk peterharperuk merged commit 54f69f4 into raspberrypi:develop Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants