Skip to content

Conversation

@michalkalinowski-
Copy link

@michalkalinowski- michalkalinowski- commented Feb 19, 2021

Adds dev_midi example

Ports midi_test example from tinyUSB repo. I've cleaned up tusb_config.h a bit and fixed up code formatting to match other pico examples.

Testing

Verified that the example builds and sends midi messages (screen shot of Pocket MIDI displaying incoming note on and note off messages):
Screenshot 2021-02-19 at 10 27 28

@kilograham kilograham changed the base branch from master to develop March 17, 2021 01:47
@kilograham
Copy link
Contributor

can you please rebase this onto develop

@kilograham kilograham changed the base branch from develop to master March 17, 2021 01:48
@infovore
Copy link

@michalkalinowski- hah, I just did almost the same thing - should have checked the open PRs first!

@michalkalinowski-
Copy link
Author

@kilograham sorry for a late reply, just rebased on develop.

@lurch
Copy link
Contributor

lurch commented Mar 23, 2021

@michalkalinowski- Can you click the "Edit" button at the top of this PR and change the base branch to raspberrypi:develop please? That should "clean up" the Commits tab in this PR 🙂

@michalkalinowski- michalkalinowski- changed the base branch from master to develop March 23, 2021 14:47
@michalkalinowski-
Copy link
Author

@michalkalinowski- Can you click the "Edit" button at the top of this PR and change the base branch to raspberrypi:develop please? That should "clean up" the Commits tab in this PR 🙂

Hmm, I still see #30 among my commits, let me see if I can quickly fix that.

@michalkalinowski-
Copy link
Author

All right, the diff looks ok now :)

README.md Outdated
[dev_hid_composite](usb/device/dev_hid_composite) | Composite HID (mouse + keyboard) example from TinyUSB
[dev_hid_generic_inout](usb/device/dev_hid_generic_inout) | Generic HID device example from TinyUSB
[dev_lowlevel](usb/device/dev_lowlevel) | A USB Bulk loopback implemented with direct access to the USB hardware (no TinyUSB)
[dev_midi](usb/device/dev_midi) | USB midi device example from TinyUSB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth mentioning here that this just sends dummy note data to the host PC? (i.e. it isn't (yet) a fully-fledged USB MIDI hardware interface) 🤷‍♂️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I've updated the readme.

@kilograham
Copy link
Contributor

Note, this will be subsumed by #99 where we will be using all TinyUSB examples directly

@kilograham kilograham closed this Apr 12, 2021
@raveslave
Copy link

now when we have this (usb host) support https://github.com/raspberrypi/pico-examples/blob/master/usb/host/host_cdc_msc_hid/main.c
anyone that would be up for adding usb midi host support as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants