USB stdio & SDK 1.1.0

[Wiz-IO]

maybe is issues...

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);
#include "hardware/regs/addressmap.h"

pico_stdio_usb\stdio_usb.c:17:8: error: unknown type name 'mutex_t'
#include "pico/mutex.h"

pico_stdio_usb\stdio_usb.c:19:13: warning: function declaration isn't a prototype [-Wstrict-prototypes]
static void low_priority_worker_irq()

[lurch]

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);

@kilograham the offending line says:

watchdog_reboot(0, SRAM_END, PICO_STDIO_USB_RESET_RESET_TO_FLASH_DELAY_MS);

but the doxygen for watchdog_reboot says "If pc is non-zero, this will be the stack pointer used.", but here pc is zero, so that would seem to imply that SRAM_END isn't needed? 🤷‍♂️

@Wiz-IO Just out of curiosity, what compiler / compiler-version / compiler-options are you using to catch those errors, which we seem to have missed ourselves? 🙂

[Wiz-IO]

Hi,

I make "experimental" platform for PlatformIO ( VSCode ) & Arduino, based on pico-sdk v1.1.0 and one last version as "backup" (v1.0.1)
Builder: https://github.com/Wiz-IO/wizio-pico
Sources: https://github.com/Wiz-IO/framework-wizio-pico

The compiler is arm-none-eabi 7.2.1
support Windows, Linux and OSX ... ( PlatformIO download this version ( pack 1.70201.0 ) auto @ PC system )
and is tested 4 years from me with ARM-s
GCC link: http://dl.platformio.org/packages/manifest.json ( search version gccarmnoneeabi 1.70201.0 @ system )

-Wall
-Wfatal-errors
-Wstrict-prototypes
-Wno-... will remove later

All default flags is here: https://github.com/Wiz-IO/wizio-pico/blob/main/builder/frameworks/common.py#L104

[kilograham]

pico_stdio_usb\stdio_usb.c:19:13: warning: function declaration isn't a prototype [-Wstrict-prototypes]
static void low_priority_worker_irq()

Yup; this isn't in our standard warning check since TinyUSB has warnings. Will fix

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);
#include "hardware/regs/addressmap.h"

pico_stdio_usb\stdio_usb.c:17:8: error: unknown type name 'mutex_t'
#include "pico/mutex.h"

Agree these should be in place, though for it to fail it implies that you have tinyusb configured not to use RP2040 target, 'cause otherwise they'd both be included via "tusb.h"

[Wiz-IO]

by the way ... Windows 10 and USB stdio

1. "HelloWorld" example with USB stdio from SDK 1.0.1 - PC driver is OK - USB stdio work
2. same example compiled with SDK 1.1.0 - PC driver unknow ( Zadig can not see the device ) - USB stdio not work
3. #define PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE 0 ( disable reset )
4. compile with SDK 1.1.0 - USB stdio is OK :)

[lurch]

@Wiz-IO That's interesting, thanks.

@kilograham I see that e.g. https://github.com/raspberrypi/tinyusb/blob/master/examples/device/hid_generic_inout/src/usb_descriptors.c#L28 says
"A combination of interfaces must have a unique product id, since PC will save device driver after the first plug.
Same VID/PID with different interface e.g MSC (first), then CDC (later) will possibly cause system error on PC."
Could that explain the behaviour that @Wiz-IO describes in his last message? If so, does that imply that "USB-CDC + USB_ENABLE_RESET" needs a different PID from just "USB-CDC"?

[kilograham]

that could certainly be it. @Wiz-IO can you try changing the line 35 in src/rp2_common/pico_stdio_usb/stdio_usb_descriptors.c

#define USBD_PID (0x000a) // Raspberry Pi Pico SDK CDC

to something else maybe 0xeeea and see if Windows likes that

[Wiz-IO]

reset enabled

reset disabled

[kilograham]

was that with zadig? i.e. did zadig not like the "new" device?

[Wiz-IO]

the driver is installed ... but win 10 work without zadig ( I do not remember )

enable/disable reset is
PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE 1/0
https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h#L72

[Wiz-IO]

btw: win 7 - unknow device for both ( driver is for SDK 1.0.1 ) - I need to delete from registry driver uuid and restart PC
( will test tomorrow )