USB stdio & SDK 1.1.0 #257

Wiz-IO · 2021-03-15T08:13:35Z

maybe is issues...

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);
#include "hardware/regs/addressmap.h"

pico_stdio_usb\stdio_usb.c:17:8: error: unknown type name 'mutex_t'
#include "pico/mutex.h"

pico_stdio_usb\stdio_usb.c:19:13: warning: function declaration isn't a prototype [-Wstrict-prototypes]
static void low_priority_worker_irq()

lurch · 2021-03-15T11:10:44Z

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);

@kilograham the offending line says:

watchdog_reboot(0, SRAM_END, PICO_STDIO_USB_RESET_RESET_TO_FLASH_DELAY_MS);

but the doxygen for watchdog_reboot says "If pc is non-zero, this will be the stack pointer used.", but here pc is zero, so that would seem to imply that SRAM_END isn't needed? 🤷‍♂️

@Wiz-IO Just out of curiosity, what compiler / compiler-version / compiler-options are you using to catch those errors, which we seem to have missed ourselves? 🙂

Wiz-IO · 2021-03-15T11:53:06Z

Hi,

I make "experimental" platform for PlatformIO ( VSCode ) & Arduino, based on pico-sdk v1.1.0 and one last version as "backup" (v1.0.1)
Builder: https://github.com/Wiz-IO/wizio-pico
Sources: https://github.com/Wiz-IO/framework-wizio-pico

The compiler is arm-none-eabi 7.2.1
support Windows, Linux and OSX ... ( PlatformIO download this version ( pack 1.70201.0 ) auto @ PC system )
and is tested 4 years from me with ARM-s
GCC link: http://dl.platformio.org/packages/manifest.json ( search version gccarmnoneeabi 1.70201.0 @ system )

-Wall
-Wfatal-errors
-Wstrict-prototypes
-Wno-... will remove later

All default flags is here: https://github.com/Wiz-IO/wizio-pico/blob/main/builder/frameworks/common.py#L104

kilograham · 2021-03-15T19:18:21Z

pico_stdio_usb\stdio_usb.c:19:13: warning: function declaration isn't a prototype [-Wstrict-prototypes]
static void low_priority_worker_irq()

Yup; this isn't in our standard warning check since TinyUSB has warnings. Will fix

pico_stdio_usb\reset_interface.c:63:32: error: 'SRAM_END' undeclared (first use in this function);
#include "hardware/regs/addressmap.h"

pico_stdio_usb\stdio_usb.c:17:8: error: unknown type name 'mutex_t'
#include "pico/mutex.h"

Agree these should be in place, though for it to fail it implies that you have tinyusb configured not to use RP2040 target, 'cause otherwise they'd both be included via "tusb.h"

Wiz-IO · 2021-03-15T22:08:06Z

by the way ... Windows 10 and USB stdio

"HelloWorld" example with USB stdio from SDK 1.0.1 - PC driver is OK - USB stdio work
same example compiled with SDK 1.1.0 - PC driver unknow ( Zadig can not see the device ) - USB stdio not work
#define PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE 0 ( disable reset )
compile with SDK 1.1.0 - USB stdio is OK :)

lurch · 2021-03-17T11:40:30Z

@Wiz-IO That's interesting, thanks.

@kilograham I see that e.g. https://github.com/raspberrypi/tinyusb/blob/master/examples/device/hid_generic_inout/src/usb_descriptors.c#L28 says
"A combination of interfaces must have a unique product id, since PC will save device driver after the first plug.
Same VID/PID with different interface e.g MSC (first), then CDC (later) will possibly cause system error on PC."
Could that explain the behaviour that @Wiz-IO describes in his last message? If so, does that imply that "USB-CDC + USB_ENABLE_RESET" needs a different PID from just "USB-CDC"?

kilograham · 2021-03-17T16:04:46Z

that could certainly be it. @Wiz-IO can you try changing the line 35 in src/rp2_common/pico_stdio_usb/stdio_usb_descriptors.c

#define USBD_PID (0x000a) // Raspberry Pi Pico SDK CDC

to something else maybe 0xeeea and see if Windows likes that

Wiz-IO · 2021-03-17T16:43:23Z

reset enabled

reset disabled

kilograham · 2021-03-17T16:48:41Z

was that with zadig? i.e. did zadig not like the "new" device?

Wiz-IO · 2021-03-17T16:50:45Z

the driver is installed ... but win 10 work without zadig ( I do not remember )

enable/disable reset is
PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE 1/0
https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_stdio_usb/include/pico/stdio_usb.h#L72

Wiz-IO · 2021-03-17T16:57:48Z

btw: win 7 - unknow device for both ( driver is for SDK 1.0.1 ) - I need to delete from registry driver uuid and restart PC
( will test tomorrow )

* pico_stdio_usb: be more explicit about includes, fix warning (#257) * pico_base: NDEBUG backwards for absolute_time_t (#255) * pico_util: missing extern C in queue.h (#249) * build: remove -march which was masking -mcpu, now SVC available (#253)

lurch · 2021-03-18T12:17:36Z

Yes, Windows 7 requires extra steps that Windows 10 doesn't - the getting started guide has a link to https://www.raspberrypi.org/forums/viewtopic.php?f=146&t=300053

kilograham · 2021-03-18T12:20:14Z

I'm super confused about what does and doesn't work now; does Windows 10 work correctly with a not seen before (different PID) device which uses the reset interface (i.e. is composite)?

Wiz-IO · 2021-03-18T12:33:34Z

#define USBD_PID (0x000a) up driver COM4
#define USBD_PID (0xeeea) up driver COM5

someone other to test Reset vendor on Win10 - it doesn't work for me - Unknown device...

kilograham · 2021-03-27T14:32:55Z

@lurch can you take a look at this to see what does and doesn't work?

lurch · 2021-03-27T14:50:12Z

@kilograham I'm afraid all my computers run Linux, I don't have anything with Windows 10 :-/ I think @liamfraser uses Windows though?

Wiz-IO · 2021-03-28T07:47:44Z

RESET_0/1.TXT mean PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE 0/1
https://github.com/Wiz-IO/framework-wizio-pico/blob/main/SDK/include/pico/stdio_usb.h#L72

logs form WIN10 ... CFG_TUSB_DEBUG=2
https://github.com/Wiz-IO/TEST

kilograham · 2021-03-28T13:18:29Z

OK, thanks that is helpful

liamfraser · 2021-03-30T14:28:27Z

@Wiz-IO if you open Zadig and List all devices what is the driver for the Board CDC interface with the standard VID + PID. It should be usbser:

Wiz-IO · 2021-03-30T14:36:26Z

my WIN-10 work without Zadig

btw: here it tries to load a second driver
https://github.com/Wiz-IO/TEST/blob/main/RESET_1.TXT#L88

kilograham · 2021-03-30T14:38:52Z

Can you please explicitly state exactly what does and does not work

You said higher above that Windows 10 does not work for you, and then you say it does work

Wiz-IO · 2021-03-30T14:53:42Z

not work reset interface
PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE = 1

Wiz-IO · 2021-03-30T15:00:28Z

IF PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE = 1 windows say unknown driver... if = 0 the driver is ok, stdio work...
sorry... i write from phone

lurch · 2021-03-30T15:40:46Z

The reset interface won't work because it's a "custom interface" which we don't supply a Windows-driver for yet.
But the USB stdio interface should still work with the RESET_VIA_VENDOR_INTERFACE enabled?

Wiz-IO · 2021-03-30T15:48:30Z

it doesn't work for me - Test it...

I have disabled it for PlatformIO port
https://github.com/Wiz-IO/framework-wizio-pico/blob/main/SDK/include/pico/stdio_usb.h#L72

lurch · 2021-03-30T15:50:58Z

As asked above, can you please show a Zadig screenshot for the Board CDC interface? You might need to enable the "list all devices" option or something.

Wiz-IO · 2021-03-30T15:57:28Z

I posted it...
#257 (comment)

kilograham · 2021-03-30T16:51:28Z

that is not what was asked for, and yes we've obviously tested it and it works fine, so we're trying to help figure out why it doesn't work on your machine

Wiz-IO · 2021-03-30T17:07:01Z

Wiz-IO · 2021-03-30T17:32:09Z

WIN 7

Wiz-IO · 2021-03-30T17:40:13Z

no reset - WIN 7 ( 10 work too )

kilograham · 2021-04-01T16:43:36Z

WIN 7

can you close the dropdown so we can see what is underneath it in this (the reset) case (show the results for both interfaces)

Wiz-IO · 2021-04-01T16:51:05Z

the Pico USB not exist in this menu

kilograham · 2021-04-01T18:41:54Z

what you have selected right there "USB Device Interface 0" and "USB Device Interface 1"

Wiz-IO · 2021-04-01T18:54:51Z

other USB drivers

kilograham · 2021-04-01T18:56:59Z

are you able to switch that to WinUSB?

Wiz-IO · 2021-04-01T19:01:38Z

Pico as WinUSB? without reset interface is OK

shot is from WIN 10

kilograham · 2021-04-01T19:05:16Z

no; are you able to switch libusbK to WinUSB on the broken versions?

Wiz-IO · 2021-04-01T19:12:33Z

no driver...

Wiz-IO · 2021-04-01T19:18:29Z

can you paste me compilator verbose log ( part )
with PICO_STDIO_USB and PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE = 1

lurch · 2021-04-01T19:53:14Z

http://www.linux-usb.org/usb.ids says that 09DA:9066 is "A4Tech Co., Ltd. F3 V-Track Gaming Mouse".

Wiz-IO · 2021-04-01T20:00:15Z

yep, it is my mouse :)

kilograham added this to the 1.1.1 milestone Mar 15, 2021

kilograham self-assigned this Mar 15, 2021

kilograham added a commit that referenced this issue Mar 15, 2021

pico_stdio_usb: be more explicit about includes, fix warning (#257)

e7693b2

kilograham mentioned this issue Mar 15, 2021

Small fixes #260

Merged

kilograham linked a pull request Mar 15, 2021 that will close this issue

Small fixes #260

Merged

philipstarkey mentioned this issue Mar 21, 2021

Board fails to connect with pico-SDK 1.1 labscript-suite/PrawnBlaster#11

Closed

kilograham assigned lurch and unassigned kilograham Mar 27, 2021

kilograham assigned liamfraser Mar 31, 2021

Wiz-IO closed this as completed Apr 1, 2021

lurch mentioned this issue Apr 16, 2021

Using Pico on Windows 7/8 is easier than documented raspberrypi/pico-feedback#118

Closed

USB stdio & SDK 1.1.0 #257

USB stdio & SDK 1.1.0 #257

Comments

Wiz-IO commented Mar 15, 2021

lurch commented Mar 15, 2021

Wiz-IO commented Mar 15, 2021 • edited Loading

kilograham commented Mar 15, 2021

Wiz-IO commented Mar 15, 2021

lurch commented Mar 17, 2021

kilograham commented Mar 17, 2021

Wiz-IO commented Mar 17, 2021

kilograham commented Mar 17, 2021

Wiz-IO commented Mar 17, 2021

Wiz-IO commented Mar 17, 2021

lurch commented Mar 18, 2021

kilograham commented Mar 18, 2021

Wiz-IO commented Mar 18, 2021

kilograham commented Mar 27, 2021

lurch commented Mar 27, 2021

Wiz-IO commented Mar 28, 2021 • edited Loading

kilograham commented Mar 28, 2021

liamfraser commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

kilograham commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

lurch commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

lurch commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

kilograham commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

Wiz-IO commented Mar 30, 2021

kilograham commented Apr 1, 2021 • edited Loading

Wiz-IO commented Apr 1, 2021 • edited Loading

kilograham commented Apr 1, 2021

Wiz-IO commented Apr 1, 2021

kilograham commented Apr 1, 2021

Wiz-IO commented Apr 1, 2021

kilograham commented Apr 1, 2021

Wiz-IO commented Apr 1, 2021

Wiz-IO commented Apr 1, 2021

lurch commented Apr 1, 2021

Wiz-IO commented Apr 1, 2021

Wiz-IO commented Mar 15, 2021 •

edited

Loading

Wiz-IO commented Mar 28, 2021 •

edited

Loading

kilograham commented Apr 1, 2021 •

edited

Loading

Wiz-IO commented Apr 1, 2021 •

edited

Loading