Skip to content

make host pico_platform.h and binary_info.h CMakeLists.txt safe for inclusion in non SDK build #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilograham merged 2 commits into from
May 11, 2021
Merged

make host pico_platform.h and binary_info.h CMakeLists.txt safe for inclusion in non SDK build #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f2c9b
make host pico_platform.h and binary_info.h CMakeLists.txt safe for i…
kilograham May 6, 2021
bc8c782
fix comment
kilograham May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/common/pico_binary_info/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ add_library(pico_binary_info_headers INTERFACE)

target_include_directories(pico_binary_info_headers INTERFACE ${CMAKE_CURRENT_LIST_DIR}/include)

pico_add_impl_library(pico_binary_info)
if (COMMAND pico_add_platform_library)
pico_add_platform_library(pico_binary_info)
else()
add_library(pico_binary_info INTERFACE)
endif()

target_link_libraries(pico_binary_info INTERFACE pico_binary_info_headers)

Expand Down
10 changes: 8 additions & 2 deletions src/host/pico_platform/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This file may be included directly by a build to get common SDK macros and types

if (NOT TARGET pico_platform_headers)
add_library(pico_platform_headers INTERFACE)

Expand All @@ -11,7 +13,11 @@ if (NOT TARGET pico_platform_headers)
endif()

if (NOT TARGET pico_platform)
pico_add_impl_library(pico_platform)
if (COMMAND pico_add_platform_library)
pico_add_platform_library(pico_platform)
else()
add_library(pico_platform INTERFACE)
endif()

target_sources(pico_platform INTERFACE
${CMAKE_CURRENT_LIST_DIR}/platform_base.c
Expand All @@ -22,4 +28,4 @@ endif()

function(pico_add_platform_library TARGET)
target_link_libraries(pico_platform INTERFACE ${TARGET})
endfunction()
endfunction()