Make script idempotent #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the script fails on the first try, and is re-run later, it fails for two reasons: - The `mkdir build` commands fail - The `git clone` for `picoprobe` and `picotool` fail because those repos have already been cloned. This PR fixes these issues. This will also supersede/obsolete raspberrypi#6 and fix raspberrypi#10.
Hmmm, if the repo directory already exists, maybe it's worth cd-ing into it and doing a |
Yes indeed, that would be nice to have, I'll do some testing around this scenario and update this PR. |
|
Superseded by #20? |
|
I think the entire repo has been superseded by #20 😀 I haven't tested that myself, but yes, if that PR is merged, this should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the script fails on the first try, and is re-run later, it fails for two reasons:
mkdir buildcommands failgit cloneforpicoprobeandpicotoolfail because those repos have already been cloned.This PR fixes these issues. This will also supersede/obsolete #6 and fix #10. Compared to #6, this PR only skips the
git clonebit if the picoprobe/picotool directory exists, but will still try to build those even if they exist. The reasoning here is that one of these builds might have failed, so we need to re-try building if the script is re-run.