BCM2712d0 support #884
Merged
BCM2712d0 support #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding review requests until I've rebuilt cleanly from this PR, and confirmed it boots on D0 and C1 variants of BCM2712. |
- Apply with p1, using a patch generated from git-format-patch. - Use POSIX 'cd' over 'pushd, popd' - Use OLDPWD to the find the patch, rather than making assumptions about the relative location of it.
|
Confirmed that the updated PR builds, boots on C1 and D0. |
lurch
reviewed
Jun 26, 2024
| # | ||
| BR2_HAVE_DOT_CONFIG=y | ||
| BR2_EXTERNAL_NAMES="IMAGER" | ||
| BR2_EXTERNAL_IMAGER_PATH="/home/tdewey/src/rpi-imager/embedded/imager" |
There was a problem hiding this comment.
Will this still build for users that don't have a /home/tdewey/... directory on their computer?
There was a problem hiding this comment.
I'll prune it, but I would expect it to be overridden at build-time. The correct way to build the Embedded Imager is to use the build.sh file, which should override these BR2_EXTERNAL directives with the buildroot invocation:
make -C "${BUILDROOT}" BR2_EXTERNAL="${PWD}/imager" rpi-imager_defconfig
There was a problem hiding this comment.
Ahhh, awesome; I didn't realise that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uprate the buildroot distribution we use for the embedded imager, selecting a new kernel, firmware and mesa in the process.
Tested on BCM2712d0.
Resolves #795