HSM: Fixup string passing of signing directives #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass the return value of get_signing_directives as a string - but then double-quote this in the invocation, mixing arguments as one. This, rightly, causes OpenSSL to complain. So, let's drop the erroneous double-quotes, and include a line to silence shellcheck in the various sites where we use the result as an argument.
|
LGTM! As an aside, we should really add 'set -e' to the various scripts invoked by systemd to more easily catch bugs / unexpected behaviour in the future. |
roliver-rpi
approved these changes
Aug 20, 2024
|
Looks good. Since are multiple HSM abstractions to choose from maybe we should 'standardize' on OPENSSL but allow a set of script helpers to re-target this for a real HSM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass the return value of get_signing_directives as a string - but then double-quote this in the invocation, mixing arguments as one.
This, rightly, causes OpenSSL to complain.
So, let's drop the erroneous double-quotes, and include a line to silence shellcheck in the various sites where we use the result as an argument.