-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate vc_vchi_dispmanx_common.h include. #166
Conversation
interface/peer/vc_vchi_dispmanx_common.h is also used in other files (on GPU side), so this change alone doesn't work for me. How about adding interface/peer/vc_vchi_dispmanx_common.h to the install header rule in CMakeLists.txt? |
Currently vc_vchi_dispmanx.h requires vc_vchi_dispmanx_common.h which is not distributed on install. This limits access to the ELEMENT_CHANGE_* defines.
@popcornmix that also works. I don't want to cause any unnecessary changes on your end. :) |
@gamaral can this PR be closed? It looks like it has been resolved. |
@popcornmix can this be merged/closed ? |
@popcornmix Are we wanting to merge this? Otherwise close I think - its ancient. |
Obviously not affecting many users, but we do provide |
firmware: Install interface/peer headers See: raspberrypi/userland#166 firmware: gx_create_window error cleanup fix See: #930 bootcode: Insert delay between disconnect and reconnect for USB device booting firmware: IL ISP: Fix the black level control to do sensible things firmware: IL ISP fixes for JC firmware: raspividyuv: Fix saving timestamps See: raspberrypi/userland#453
firmware: Install interface/peer headers See: raspberrypi/userland#166 firmware: gx_create_window error cleanup fix See: raspberrypi/firmware#930 bootcode: Insert delay between disconnect and reconnect for USB device booting firmware: IL ISP: Fix the black level control to do sensible things firmware: IL ISP fixes for JC firmware: raspividyuv: Fix saving timestamps See: raspberrypi/userland#453
- firmware: pwm_sdm multi-write support See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445 - firmware: Remove cmaservice as it doesn't work reliably - firmware: New mailbox fns for peripheral access See: raspberrypi/linux#2222 - firmware: image_encode and JPEG codec fixes See: raspberrypi/userland#435 - firmware: vc_image fixups See: raspberrypi/userland#433 - firmware: Support for independant display configuration - firmware: arm_dt: Fixup camera gpios if overrides are found in dtoverlay - firmware: mjpeg encoder: Add new thread to do the encoding - firmware: arm_dt: Suppress non-fatal errors See: #906 - firmware: dtoverlay: Create "/aliases" node when needed See: #906 - firmware: dtoverlay app: Keep overlay symbols private - firmware: dtoverlay app: Report unknown parameters in help - firmware: IL ISP: Remove DPCM10_8 compressed input - firmware: mmal_il: Add missing mappings for 8 bit Bayer encodings - firmware: IMX219 tuning: enable motion detection - firmware: IL camera: increase minimum resolution to 32x32 - firmware: audioplus: hdmi: Remove spamming logging message - firmware: arm_loader: Make program_usb_boot_mode more flexible - firmware: ov5647: Comment Y offset in mode 5 (2x2 binned 16:9) - firmware: Video encode: Add option to set number of droppable P frames See: https://www.raspberrypi.org/forums/viewtopic.php?f=38&t=201882 - firmware: i2c_gpio: Preserve errors when asserts are suppressed - firmware: power: Refactor get/set_voltage API, add SDRAM voltage - firmware: Install interface/peer headers See: raspberrypi/userland#166 - firmware: gx_create_window error cleanup fix See: #930 bootcode: Insert delay between disconnect and reconnect for USB device booting - firmware: IL ISP: Fix the black level control to do sensible things - firmware: IL ISP fixes for JC - firmware: raspividyuv: Fix saving timestamps See: raspberrypi/userland#453 - firmware: tidy: Platform cull - firmware: Default to audio_pwm_mode=2 See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=195178 - firmware: arm_loader: Distinguish multiple turbo users power: Used cached values for reads See: Hexxeh/rpi-firmware#165 - firmware: dtoverlay: Use SUDO_USER in -pre and -post scripts bootcode: Fix network booting on Pi1/Pi2 See: #935 - firmware: arm_loader: Fix power-related crashes around bootup See: Hexxeh/rpi-firmware#165 - firmware: imx219: Increase max frame rate at 640x480 to 200fps - firmware: vc_image: Add plumbing for side-by-side YUV420 format - firmware: arm_loader: Cache the non-limited voltage See: Hexxeh/rpi-firmware#165 - firmware: IL video_encode: Fix small memory leak - firmware: arm_loader: Add get_throttled mailbox call See: raspberrypi/linux#2367 - firmware: video_encode: Free conv and subsample pools on disabling port - firmware: camera: Set fixed sensor mode on all sensors - firmware: Remove intermediate use of RGB888 in converting I420 to BGR888 - firmware: camera: Remove video tone mapping curves - firmware: camera: AGC should not copy the tone map from VIDEO to STILLS - firmware: arm_dt: Fix up case of NUM_CAMERAS = -1 - firmware: dtoverlay: Also allow fragment-<n> in overlays - firmware: i2c_gpio: Optimise and run clients faster - firmware: Rework the frequency/voltage scaling logic - firmware: Clamp SDRAM frequencies only when sdm audio is active See: Hexxeh/rpi-firmware#172 - firmware: arm_dt: Improve DTB location, upstream kernel support See: #943 - firmware: platform: Should limit sdram voltage when turbo is throttled - firmware: video_decode: Allow setting the output format twice - firmware: vmcs: Increase service limit for vcsm to 2 - firmware: arm_dt: Restore support for user-selected DTB file See: #943 - firmware clock: WIP: Avoid temporary high clock when switching PLL and divisor See: https://forum.kodi.tv/showthread.php?tid=298461&pid=2713270#pid2713270 - firmware: platform: Make sure boosted frequency uses boosted voltage - firmware: power: Add 10ms timeout for PMIC voltage control - firmware: platform: Reduce i2c-gpio clock speed back to 200KHz - firmware: ldconfig: Support Pi3+ and Pi0W sections - firmware: platform: Update firmware dt-blob for pi3+ - firmware: video_decode: Allow setting the resolution on the output port - firmware: arm_loader: Fall back to stored frequency for clocks platform doesn't have fixed values for See: #951
Currently vc_vchi_dispmanx.h includes vc_vchi_dispmanx_common.h which is
not distributed on install. This limits access to the ELEMENT_CHANGE_*
defines.
It's not needed in the header itself, it works just fine in the
implementation file.