Remove vcfiled/vcfilesys, and a couple of MMAL cleanups #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both these libraries/apps were related to the VPU accessing the host file system over VCHI. This has never been used on the Pi, and is creating build warnings with the latest versions of gcc. Remove them from the source tree.
The examples read the first 512 bytes of the stream and try stuffing them into the codec as header bytes. If running a debug build of MMAL this will fail as the extradata field of the port format is bigger than MMAL_FORMAT_EXTRADATA_MAX_SIZE Reduce the header bytes array down to 128bytes to match MMAL_FORMAT_EXTRADATA_MAX_SIZE.
…res. Adds the equivalent to "Add option to start in burst mode if AE settings are manual" patch to RaspiStillYUV so it too can drop straight into capture mode. See raspberrypi#640
|
Looks good to me. I'll just give popcormix a chance to reprieve vcfiled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcfiled/vcfilesys removal as per #631 #635 #644
A couple of minor MMAL cleanups whilst I was creating a userland PR. One for debug builds of the examples, and one so RaspiStillYUV matched Raspstill.