Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit that libfdt should be built static #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crabbedhaloablution
Copy link

To avoid issues such as #333 , make explicit that libfdt should be built as static.
This will allow raspberrypi-userland to more easily integrate with distributions which automatically add -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF to their CMake flags.

crabbedhaloablution added a commit to crabbedhaloablution/raspberrypi-mainline that referenced this pull request Nov 8, 2020
@HinTak
Copy link

HinTak commented Nov 8, 2020

I don't think it is advisable to guess what distributions need or do not need, unless you represent one of such distributions.

@crabbedhaloablution
Copy link
Author

I'm working on a respin of the Gentoo ebuild. The default behavior of Gentoo matches that seen in #333 .
The change is null for anyone else. I see no reason why it shouldn't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants