Make explicit that libfdt should be built static #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crabbedhaloablution
added a commit
to crabbedhaloablution/raspberrypi-mainline
that referenced
this pull request
Nov 8, 2020
…remove hacky sed
|
I don't think it is advisable to guess what distributions need or do not need, unless you represent one of such distributions. |
|
I'm working on a respin of the Gentoo ebuild. The default behavior of Gentoo matches that seen in #333 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues such as #333 , make explicit that libfdt should be built as static.
This will allow raspberrypi-userland to more easily integrate with distributions which automatically add -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF to their CMake flags.