Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug-related code from vc_image_structs.h #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torralbaa
Copy link

The removed lines currently cause the compilation of programs that depend on vc_image_structs.h to fail, since helpers/debug_utils/debug_writer.h does not exist, nor do the DEBUG_* types.

@popcornmix
Copy link
Contributor

@6by9 looks like one of your commits - do we use this?

@6by9
Copy link
Contributor

6by9 commented Apr 26, 2021

vc_image_structs.h was broken out so that it could be used from userland without needing the full vc_image stuff.

vcdbg is the most likely candidate to be using it, but I thought your magic scripts only picked up files that are actually used by the build. I'm surprised we need almost any of these vc_image headers for the public userland repo.

@6by9
Copy link
Contributor

6by9 commented Apr 26, 2021

rm -rf helpers/vc_image and ./buildme runs quite happily.
Likewise vcinclude/vc_image_types.h appears unused.

(helpers/v3d/v3d_common.h appears unused too)

@torralbaa
Copy link
Author

torralbaa commented Apr 26, 2021

Hello,

This file seems to be unused by the userland itself, but some programs depend on it. I came here from a forum post by @6by9, and while it's stated that the program shouldn't be used as a "good example", I thought removing the "bad" lines here would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants