Document return values of bcm_host_get_peripheral_* functions for clarity #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity. Signed-off-by: Daniel Indictor <daniel.indictor@gmail.com>
DanielIndictor
force-pushed
the
docfix_bcm_host_peripheral_address
branch
from
ff57a5d
to
4a36e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by why the datasheet reported a different value for the base address of the peripherals than this function returned, so I had to read the implementation, trace that to the dtb source code, and find the appropriate line in the kernel code. Hopefully documenting this will save somebody some time in the future!