Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileSync replaces postfix empty string option with '.tmp' #182

Closed
gutte opened this issue Jan 10, 2019 · 1 comment · May be fixed by mike-north/devcert#45 or sekikn/avro#9
Closed

fileSync replaces postfix empty string option with '.tmp' #182

gutte opened this issue Jan 10, 2019 · 1 comment · May be fixed by mike-north/devcert#45 or sekikn/avro#9

Comments

@gutte
Copy link

gutte commented Jan 10, 2019

Expected Behavior

Using the option: { postfix : '' } should omit the postfix completely from the filename.
This is how the async file method behaves.

Experienced Behavior

The postfix option is replaced with '.tmp', making it impossible to use a filename with no postfix.
gutte added a commit to gutte/node-tmp that referenced this issue Jan 10, 2019
@gutte
fix raszi#182 fileSync takes empty string postfix option
636e84b
@silkentrance
Copy link
Collaborator

Ah now this makes sense :) well, done.

silkentrance added a commit that referenced this issue Jan 10, 2019
@silkentrance
Merge pull request #183 from gutte/master
77d8e7e 
fix #182 fileSync takes empty string postfix option
@silkentrance silkentrance mentioned this issue Jan 12, 2019
Merged
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
Merge pull request #184 from raszi/gh-182
84cea56 
test: add missing tests for #182
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
fix #187: restore behaviour for #182
a66023a
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
fix #187: restore behaviour for #182
d81078b
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
fix #187: restore behaviour for #182
afdc6ae
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
fix #187: restore behaviour for #182
0f7a3d4 
chore(docs): add info about compatibility on signal handling
silkentrance added a commit that referenced this issue Mar 20, 2019
@silkentrance
Merge pull request #188 from raszi/gh-187
05aba23 
HOTFIX #187: restore behaviour for #182
This was referenced Mar 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gutte @silkentrance