Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dir option must always be relative to the standard tmp directory #207

Closed
silkentrance opened this issue Jan 15, 2020 · 2 comments
Closed

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jan 15, 2020

The dir option must be relative to the existing tmp directory that is provided by the process environment.

tmp will expect that the so defined directory is in place, otherwise it will fail as it will not create the directory by itself.

The current solution may pose issues and potential risk, see #205

The tmp directory should always and only be configured in the process environment and not by the application itself.

This might have a potential impact on existing applications and the change must be communicated well.

@silkentrance silkentrance changed the title dir option must be relative to the standard tmp directory dir option must always be relative to the standard tmp directory Jan 15, 2020
@silkentrance silkentrance self-assigned this Jan 24, 2020
@silkentrance
Copy link
Collaborator Author

see also #219

@silkentrance
Copy link
Collaborator Author

silkentrance commented Feb 3, 2020

having a dir option that is always relative to the os/environment provided temporary directory requires tmp to recursively create that directory, if it does not exist in order to relieve the user from doing so in every one of his applications.

we could use https://github.com/substack/node-mkdirp for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant