Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues and issues with test tmp file/dir naming #214

Closed
silkentrance opened this issue Jan 24, 2020 · 0 comments · May be fixed by mike-north/devcert#45 or sekikn/avro#9
Closed

Fix linter issues and issues with test tmp file/dir naming #214

silkentrance opened this issue Jan 24, 2020 · 0 comments · May be fixed by mike-north/devcert#45 or sekikn/avro#9
Assignees
@silkentrance
Labels
enhancement

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jan 24, 2020 •
edited
Loading

  • get rid of unused imports
  • fix linting problems
  • generate only tmp- prefixed names so that one can see at a glance on whether the tests failed to clean up after themselves, also making it easier to clean up manually
  • octal numbers must be encoded 0oDDD instead of just 0DDD.
  • add missing comments
@silkentrance silkentrance self-assigned this Jan 24, 2020
@silkentrance silkentrance changed the title Existing tests must be refactored Fix linter issues and issues with test tmp file/dir naming Jan 27, 2020
silkentrance added a commit that referenced this issue Jan 27, 2020
@silkentrance
Merge pull request #223 from raszi/gh-214
eb412d6 
fix #214: refactor tests and lib
This was referenced Mar 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silkentrance silkentrance

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@silkentrance