-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #121 #159
fix #121 #159
Conversation
@raszi we definitely need linting rules in place, so you do not have to this 😁 |
We do have linting rules. We did not have a task for it, but here is a PR for that in #163. |
23f22ec
to
5283167
Compare
0c339fb
to
9fc4f9a
Compare
rebased to master |
Tests require a lot more work. I am on it but it will take some time as I am currently working on multiple other things as well. |
2f0bf89
to
a2efe09
Compare
appveyor is broken, all tests have passed and still they report failing builds... |
It seems as if there is some process still running, causing a timeout for the builds on appveyor. |
This seems to be a long standing issue |
Regardless of the fact that the tests are all off, not to mention that they are all shize. Need to fix these ASAP. signal parameter is never passed, need to investitate why. |
Heck, I need a windoze machine for this finally to be resolved. |
5600dce
to
2e5fed9
Compare
The fix does not work on windows. In fact, appveyor builds will timeout after 1hr. sigh more work to be done to fix this for this darn platform. I need to be able to cancel build jobs on appveyor #185. |
db4e7c5
to
d9ed736
Compare
hell, even with the latest changes, the SIGINT listener will not be called on windows... |
88e2ee1
to
dc55725
Compare
Signal handling on the Windoze platform is not an option. Support is available for OSX/Linux only, starting with node > 6. Node 6 on Linux has issues that will prevent the signal SIGINT listener from being called. |
I am giving up on making this work on Windoze using standard node provided IPC/process signalling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, this is a nice PR @silkentrance, thank you very much!
My only problem is that this whole graceful cleanup was just a small feature of this library and now we are having hard time supporting it. I believe we should consider dropping it in the near future.
You are welcome. Thank you very much. Yeah, the graceful cleanup stuff is getting out of hand :) And it also comes with the safe installation of the listeners, something that is required for this to work flawlessly with the jest testing framework. I will look into this and see whether it can be simplified. Maybe we can externalise parts of this by exposing the garbage collector? |
dropping support for node v6.x as it is not working correctly with the installed SIGINT handlers add appveyor build for node 11
and sending it a CTRL-C signal requires a console on Windoze, which is not what tmp is about
we might add additional tests for this, but, frankly, I am sick of the Windoze platform and will not be
implementing any more work arounds or even dedicated tests for it