Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid relying on Node’s internals #166

Merged
merged 1 commit into from
Jan 28, 2018
Merged

fix: avoid relying on Node’s internals #166

merged 1 commit into from
Jan 28, 2018

Commits on Jan 27, 2018

  1. Avoid relying on Node’s internals 

    `process.binding()` is an internal API of Node, and
its use should be avoided.

Modern versions of Node have `constants` properties
on the individual public modules, so using these
and falling back to the `process.binding()` path
ensures that this module is unaffected by
changes to Node’s internals.
    @addaleax
    addaleax committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    f2609c9 View commit details
    Browse the repository at this point in the history